2022-02-25 10:55:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume

On Fri, Feb 25, 2022 at 01:53:11PM +0800, Henry Lin wrote:
> USB2 resume starts with usb_hcd_start_port_resume() in port status
> change handling for RESUME link state. usb_hcd_end_port_resume() call is
> needed to keep runtime PM balance.
>
> Signed-off-by: Henry Lin <[email protected]>
> ---
> drivers/usb/host/xhci-hub.c | 2 ++
> 1 file changed, 2 insertions(+)

What commit does this fix?


2022-02-25 13:16:40

by Henry Lin

[permalink] [raw]
Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume

It fixes side effect from below change.

commit a231ec41e6f6433daf4c693f169f6c5cfda8cb9d
Author: Mathias Nyman <[email protected]>
Date: Fri Dec 7 16:19:35 2018 +0200

xhci: refactor U0 link state handling in get_port_status

Move U0 link state handing to USB3 and USB2 specific functions

Note that
bus_state->resuming_ports:
bus_state->resume_done[]:
are only used for USB2, and don't need to cleared for USB3 ports

No functional changes

Signed-off-by: Mathias Nyman <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

--nvpublic
________________________________________
From: Greg Kroah-Hartman <[email protected]>
Sent: Friday, February 25, 2022 2:23 PM
To: Henry Lin
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume

External email: Use caution opening links or attachments


On Fri, Feb 25, 2022 at 01:53:11PM +0800, Henry Lin wrote:
> USB2 resume starts with usb_hcd_start_port_resume() in port status
> change handling for RESUME link state. usb_hcd_end_port_resume() call is
> needed to keep runtime PM balance.
>
> Signed-off-by: Henry Lin <[email protected]>
> ---
> drivers/usb/host/xhci-hub.c | 2 ++
> 1 file changed, 2 insertions(+)

What commit does this fix?