On Wed, Feb 8, 2023 at 8:57 PM Asmaa Mnebhi <[email protected]> wrote:
>
> This series of patches creates a pin controller driver and GPIO
> driver for NVIDIA BlueField-3 SoC.
> The first patch creates a GPIO driver for handling interrupts and
> allowing the change of direction and value of a GPIO if needed.
> The second patch creates a pin controller driver for allowing a
> select number of GPIO pins to be manipulated from userspace or
> the kernel.
Please, make sure your patches are available on lore.kernel.org. I
can't find this at all.
> drivers/gpio/gpio-mlxbf3.c | 312 ++++++++++++++++++++++++++++
I'm wondering if you have anything in common with gpio-mlxbf and/or
gpio-mlxbf2 drivers. If so, can you split a common library code?
--
With Best Regards,
Andy Shevchenko
Hi Andy,
Thank you for your response. I was just going to contact you regarding this. I successfully sent these patches to you, Linus and Bartosz while they failed to get delivered to the "*.kernel.org" emails below:
[email protected];
[email protected];
[email protected]
Have these emails changed?
These patches don't have much in common with gpio-mlxbf or gpio-mlxbf2 because the hardware registers and logic have changed across generations. The only similar code between gpio-mlxbf2.c and gpio-mlxbf3.c is the irq handling.
Thanks.
Asmaa
-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Thursday, February 9, 2023 5:28 PM
To: Asmaa Mnebhi <[email protected]>
Cc: [email protected];
On Fri, Feb 10, 2023 at 12:48 AM Asmaa Mnebhi <[email protected]> wrote:
First of all, do not top-post!
> Thank you for your response. I was just going to contact you regarding this. I successfully sent these patches to you, Linus and Bartosz while they failed to get delivered to the "*.kernel.org" emails below:
> [email protected];
> [email protected];
> [email protected]
>
> Have these emails changed?
No, but you need to work with your company's IT to understand what's
going on. Your mails are only available privately and not in the
archives on lore.kernel.org. This is an issue and I'm not going to
comment on something that was not in public.
> These patches don't have much in common with gpio-mlxbf or gpio-mlxbf2 because the hardware registers and logic have changed across generations. The only similar code between gpio-mlxbf2.c and gpio-mlxbf3.c is the irq handling.
I see, don't forget to put it in the cover letter for the next version
(you will send it when you will be sure that emails are going to the
kernel.org archives).
--
With Best Regards,
Andy Shevchenko
On Fri, Feb 10, 2023 at 12:15:15PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 10, 2023 at 12:48 AM Asmaa Mnebhi <[email protected]> wrote:
>
> First of all, do not top-post!
>
> > Thank you for your response. I was just going to contact you regarding this. I successfully sent these patches to you, Linus and Bartosz while they failed to get delivered to the "*.kernel.org" emails below:
> > [email protected];
> > [email protected];
> > [email protected]
> >
> > Have these emails changed?
>
> No, but you need to work with your company's IT to understand what's
> going on. Your mails are only available privately and not in the
> archives on lore.kernel.org. This is an issue and I'm not going to
> comment on something that was not in public.
To illustrate what I'm talking about:
https://lore.kernel.org/linux-gpio/CACRpkdZ_sPCa+Q6MWUKj1ytCe5AxTp--bMmbRTUfsNO0kZTMpQ@mail.gmail.com/T/#t
> > These patches don't have much in common with gpio-mlxbf or gpio-mlxbf2 because the hardware registers and logic have changed across generations. The only similar code between gpio-mlxbf2.c and gpio-mlxbf3.c is the irq handling.
>
> I see, don't forget to put it in the cover letter for the next version
> (you will send it when you will be sure that emails are going to the
> kernel.org archives).
--
With Best Regards,
Andy Shevchenko
To illustrate what I'm talking about:
https://lore.kernel.org/linux-gpio/CACRpkdZ_sPCa+Q6MWUKj1ytCe5AxTp--bMmbRTUfsNO0kZTMpQ@mail.gmail.com/T/#t
Thanks for your help! Here is the v3 patch:
https://lore.kernel.org/lkml/[email protected]/
Best,
Asmaa