2020-01-14 10:05:10

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.4 24/78] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu

From: Chunming Zhou <[email protected]>

commit db4ff423cd1659580e541a2d4363342f15c14230 upstream.

Can expose it now that the khronos has exposed the
vlk extension.

Signed-off-by: Chunming Zhou <[email protected]>
Reviewed-by: Flora Cui <[email protected]>
Reviewed-by: Christian König <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1422,7 +1422,8 @@ static struct drm_driver kms_driver = {
.driver_features =
DRIVER_USE_AGP | DRIVER_ATOMIC |
DRIVER_GEM |
- DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ,
+ DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ |
+ DRIVER_SYNCOBJ_TIMELINE,
.load = amdgpu_driver_load_kms,
.open = amdgpu_driver_open_kms,
.postclose = amdgpu_driver_postclose_kms,



2020-01-14 14:33:03

by Deucher, Alexander

[permalink] [raw]
Subject: RE: [PATCH 5.4 24/78] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu

[AMD Public Use]

> -----Original Message-----
> From: Greg Kroah-Hartman <[email protected]>
> Sent: Tuesday, January 14, 2020 5:01 AM
> To: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>;
> [email protected]; Zhou, David(ChunMing) <[email protected]>;
> Cui, Flora <[email protected]>; Koenig, Christian
> <[email protected]>; Deucher, Alexander
> <[email protected]>
> Subject: [PATCH 5.4 24/78] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to
> amdgpu
>
> From: Chunming Zhou <[email protected]>
>
> commit db4ff423cd1659580e541a2d4363342f15c14230 upstream.
>
> Can expose it now that the khronos has exposed the vlk extension.
>
> Signed-off-by: Chunming Zhou <[email protected]>
> Reviewed-by: Flora Cui <[email protected]>
> Reviewed-by: Christian König <[email protected]>
> Signed-off-by: Alex Deucher <[email protected]>
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>

This can be dropped for 5.4. According to ChunMing, there is missing functionality in 5.4 so it's not required.

Thanks,

Alex

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1422,7 +1422,8 @@ static struct drm_driver kms_driver = {
> .driver_features =
> DRIVER_USE_AGP | DRIVER_ATOMIC |
> DRIVER_GEM |
> - DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ,
> + DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ |
> + DRIVER_SYNCOBJ_TIMELINE,
> .load = amdgpu_driver_load_kms,
> .open = amdgpu_driver_open_kms,
> .postclose = amdgpu_driver_postclose_kms,
>

2020-01-14 14:40:55

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 24/78] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu

On Tue, Jan 14, 2020 at 02:31:26PM +0000, Deucher, Alexander wrote:
> [AMD Public Use]
>
> > -----Original Message-----
> > From: Greg Kroah-Hartman <[email protected]>
> > Sent: Tuesday, January 14, 2020 5:01 AM
> > To: [email protected]
> > Cc: Greg Kroah-Hartman <[email protected]>;
> > [email protected]; Zhou, David(ChunMing) <[email protected]>;
> > Cui, Flora <[email protected]>; Koenig, Christian
> > <[email protected]>; Deucher, Alexander
> > <[email protected]>
> > Subject: [PATCH 5.4 24/78] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to
> > amdgpu
> >
> > From: Chunming Zhou <[email protected]>
> >
> > commit db4ff423cd1659580e541a2d4363342f15c14230 upstream.
> >
> > Can expose it now that the khronos has exposed the vlk extension.
> >
> > Signed-off-by: Chunming Zhou <[email protected]>
> > Reviewed-by: Flora Cui <[email protected]>
> > Reviewed-by: Christian K?nig <[email protected]>
> > Signed-off-by: Alex Deucher <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> >
>
> This can be dropped for 5.4. According to ChunMing, there is missing functionality in 5.4 so it's not required.

Ok, thanks for letting me know, now dropped.

greg k-h