2019-12-20 10:05:12

by Kishon Vijay Abraham I

Subject: [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port

No functional change. Get "struct pcie_port *" from private data
pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make
it look similar to how "struct pcie_port *" is obtained in
dw_pcie_irq_domain_alloc()

Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 395feb8ca051..c3d72b06e964 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -236,7 +236,7 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain,
unsigned int virq, unsigned int nr_irqs)
{
struct irq_data *d = irq_domain_get_irq_data(domain, virq);
- struct pcie_port *pp = irq_data_get_irq_chip_data(d);
+ struct pcie_port *pp = domain->host_data;
unsigned long flags;

raw_spin_lock_irqsave(&pp->lock, flags);
--
2.17.1

2019-12-20 10:09:04

by Gustavo Pimentel

Subject: RE: [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port

On Fri, Dec 20, 2019 at 10:5:50, Kishon Vijay Abraham I <[email protected]>
wrote:

> No functional change. Get "struct pcie_port *" from private data
> pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make
> it look similar to how "struct pcie_port *" is obtained in
> dw_pcie_irq_domain_alloc()
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 395feb8ca051..c3d72b06e964 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -236,7 +236,7 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain,
> unsigned int virq, unsigned int nr_irqs)
> {
> struct irq_data *d = irq_domain_get_irq_data(domain, virq);
> - struct pcie_port *pp = irq_data_get_irq_chip_data(d);
> + struct pcie_port *pp = domain->host_data;
> unsigned long flags;
>
> raw_spin_lock_irqsave(&pp->lock, flags);
> --
> 2.17.1


Acked-by: Gustavo Pimentel <[email protected]>

2020-05-22 11:32:03

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port

On Fri, Dec 20, 2019 at 03:35:50PM +0530, Kishon Vijay Abraham I wrote:
> No functional change. Get "struct pcie_port *" from private data
> pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make
> it look similar to how "struct pcie_port *" is obtained in
> dw_pcie_irq_domain_alloc()
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied (eventually) to pci/dwc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 395feb8ca051..c3d72b06e964 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -236,7 +236,7 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain,
> unsigned int virq, unsigned int nr_irqs)
> {
> struct irq_data *d = irq_domain_get_irq_data(domain, virq);
> - struct pcie_port *pp = irq_data_get_irq_chip_data(d);
> + struct pcie_port *pp = domain->host_data;
> unsigned long flags;
>
> raw_spin_lock_irqsave(&pp->lock, flags);
> --
> 2.17.1
>