2002-01-23 23:07:01

by Marcelo Tosatti

[permalink] [raw]
Subject: Linux 2.4.18-pre7


Hi,

So here goes pre7.

pre7:

- Make ext2/minix/sysvfs actually operate
synchronously on directories when using
the sync mount option (Andrew Morton)
- AFFS update (Roman Zippel)
- Fix 3dfx fb crash with high pixelclock (Jurriaan on Alpha)
- PATH_MAX POSIX compliance (Rusty Russell)
- Really apply AMD Elan patch (me)
- Don't drop IP packets with less than 8 bytes
of payload (David S. Miller)
- Netfilter update (Netfilter team)
- Backport 2.5 sb_bread() changes (Alexander Viro)
- Fix AF_UNIX fd leak (David S. Miller)
- Add Audigy Gameport PCI ID (Daniel Bertrand)
- Sync with ia64 arch independant parts (Keith Owens)
- APM fixes (Stephen Rothwell)
- fs/super.c cleanups (Alexander Viro)

pre6:

- Removed patch in icmp code: its
not needed and causes problems (me)

pre5:

- Include missing radeonfb defines (Erik Andersen)
- Fix fs/buffer.c thinko introduced in pre4 (Andrew Morton)
- USB bugfixes (Greg KH)
- Make fat work correctly with gcc-3.0.x (Tom Rini)
- Avoid overusage of the vmalloc area by
NTFS (Anton Altaparmakov)
- atyfb: Decrease clock rate for 3d RAGE XL (David S. Miller)
- Sungem driver bugfixes (David S. Miller)
- More networking updates (David S. Miller)
- More SPARC updates (David S. Miller)
- devfs update (Richard Gooch)
- Reiserfs expanding truncate fix (Chris Mason)
- ext3 update (Andrew Morton/Stephen Tweedie)
- Add support to WDIOC_SETTIMEOUT on several
watchdog drivers (Joel Becker)
- dl2k driver update (Jeff Garzik)
- Orinoco driver update (David Gibson)
- Radeonfb driver update (Ani Joshi)
- Avoid free_swap_and_cache() from leaving
freeable pages on the cache (Hugh Dickins)
- Add workarounds for AMD Elan processors (Robert Schwebel)
- Random pmac driver bugfixing (Benjamin Herrenschmidt)
- emu10k1 driver update (Rui Sousa)

pre4:

- Networking updates (David S. Miller)
- clgenfb update (Jeff Garzik)
- 8139cp: make it faster (Jeff Garzik)
- 8139too: fix bugs, add experimental RX reset (Jeff Garzik)
- Add MII ethtool interface and change
several drivers to support that (Jeff Garzik)
- Fix ramdisk corruption problems (Andrea Arcangeli)
- Correct in-kernel MS_ASYNC behaviour
on msync/fsync() (Andrew Morton)
- Fix PLIP problems (Niels Jensen)
- Fix problems triggered by the "fsx test"
on smbfs (Urban Widmark)
- Turn on OOSTORE for IDT winchip (from -ac tree)
- Fix iphase crash (from -ac tree)
- Fix crash with two mxser cards (from -ac tree)
- Fix tty write block bug (from -ac tree)
- Add mono/stereo detect to gemtek pci radio (from -ac tree)
- Fix sf16fmi crash on load (from -ac tree)
- add CP1250 (windows eastern european)
translation table (from -ac tree)
- cs46xx driver update (from -ac tree)
- Fix rare data loss case with RAID-1 (Ingo Molnar)
- Add 2.5.x compatibility for the kdev_t
changes (me)
- SPARC updates (David S. Miller)

pre3:

- Cris arch merge (Bjorn Wesen)
- Finish PPC merge (Benjamin Herrenschmidt)
- Add Dell PowerEdge 2400 to
"use BIOS to reboot" blacklist (Arjan van de Ven)
- Avoid potential oops at module unload with
cyclades driver (Andrew Morton)
- Gracefully handle SCSI initialization
failures (Pete Zaitcev)
- USB update (Greg KH)
- Fix potential oops while ejecting ide cds (Zwane Mwaikambo)
- Unify page freeing codepaths (Benjamin LaHaise)
- Miata dma corruption workaround (Richard Henderson)
- Fix vmalloc corruption problem on machines
with virtual dcaches (Ralf Baechle)
- Reiserfs fixes (Oleg Drokin)
- DiskOnChip driver update (David Woodhouse)
- Do not inherit page locking rules across
fork/exec (Dave Anderson)
- Add DRM 4.0 for XFree 4.0 users convenience (Christoph Hellwig)
- Replace .text.lock with .subsection (Keith Owens)
- IrDA bugfixes (Jean Tourrilhes)

pre2:

- APIC LVTERR fixes (Mikael Pettersson)
- Fix ppdev ioctl oops and deadlock (Tim Waugh)
- parport fixes (Tim Waugh)
- orinoco wireless driver update (David Gibson)
- Fix oopsable race in binfmt_elf.c (Alexander Viro)
- Small sx16 driver bugfix (Heinz-Ado Arnolds)
- sbp2 deadlock fix (Andrew Morton)
- Fix JFFS2 write error handling (David Woodhouse)
- Intermezzo update (Peter J. Braam)
- Proper AGP support for Intel 830MP chipsets (Nicolas Aspert)
- Alpha fixes (Jay Estabrook)
- 53c700 SCSI driver update (James Bottomley)
- Fix coredump mmap_sem deadlock on IA64 (David Mosberger)
- 3ware driver update (Adam Radford)
- Fix elevator insertion point on failed
request merge (Jens Axboe)
- Remove bogus rpciod_tcp_dispatcher definition (David Woodhouse)
- Reiserfs fixes (Oleg Drokin)
- de4x5 endianess fixes (Kip Walker)
- ISDN CAPI cleanup (Kai Germaschewski)
- Make refill_inactive() correctly account
progress (me)

pre1:

- S390 merge (IBM)
- SuperH merge (SuperH team)
- PPC merge (Benjamin Herrenschmidt)
- PCI DMA update (David S. Miller)
- radeonfb update (Ani Joshi)
- aty128fb update (Ani Joshi)
- Add nVidia GeForce3 support to rivafb (Ani Joshi)
- Add PM support to opl3sa2 (Zwane Mwaikambo)
- Basic ethtool support for 3com, starfire
and pcmcia net drivers (Jeff Garzik)
- Add MII ethtool interface (Jeff Garzik)
- starfire,sundance,dl2k,sis900,8139{too,cp},
natsemi driver updates (Jeff Garzik)
- ufs/minix: mark inodes as bad in case of read
failure (Christoph Hellwig)
- ReiserFS fixes (Oleg Drokin)
- sonypi update (Stelian Pop)
- n_hdlc update (Paul Fulghum)
- Fix compile error on aty_base.c (Tobias Ringstrom)
- Document cpu_to_xxxx() on kernel-hacking doc (Rusty Russell)
- USB update (Greg KH)
- Fix sysctl console loglevel bug on
IA64 (and possibly other archs) (Jesper Juhl)
- Update Athlon/VIA PCI quirks (Calin A. Culianu)
- blkmtd update (Simon Evans)
- boot protocol update (makes the highest
possible initrd address available to the
bootloader) (H. Peter Anvin)
- NFS fixes (Trond Myklebust)


2002-01-23 23:20:42

by CaT

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7

On Wed, Jan 23, 2002 at 07:55:46PM -0200, Marcelo Tosatti wrote:
> - Netfilter update (Netfilter team)

This appears to include the fix for the crash bug I reported earlier
involving ipchains compatability and redirects appears to be in this. :)

Woo. :)

--
SOCCER PLAYER IN GENITAL-BITING SCANDAL --- "It was something between
friends that I thought would have no importance until this morning when
I got up and saw all the commotion in the news," Gallardo told a news
conference. "It stunned me."
Reyes told Marca that he had "felt a slight pinch."
-- http://www.azcentral.com/offbeat/articles/1129soccer29-ON.html

2002-01-23 23:47:12

by Stephan von Krawczynski

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7: compile error

>
> Hi,
>
> So here goes pre7.
>
> pre7:
>
> - Make ext2/minix/sysvfs actually operate
> synchronously on directories when using
> the sync mount option (Andrew Morton)
> - AFFS update (Roman Zippel)
> - Fix 3dfx fb crash with high pixelclock (Jurriaan on Alpha)
> - PATH_MAX POSIX compliance (Rusty Russell)
> - Really apply AMD Elan patch (me)
> - Don't drop IP packets with less than 8 bytes
> of payload (David S. Miller)
> - Netfilter update (Netfilter team)
> - Backport 2.5 sb_bread() changes (Alexander Viro)
> - Fix AF_UNIX fd leak (David S. Miller)
> - Add Audigy Gameport PCI ID (Daniel Bertrand)
> - Sync with ia64 arch independant parts (Keith Owens)
> - APM fixes (Stephen Rothwell)
> - fs/super.c cleanups (Alexander Viro)

"I am sorry, Dave. I'm afraid I can't do that":

gcc -D__KERNEL__ -I/usr/src/linux-2.4.18-pre7/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -DMODULE -DKBUILD_BASENAME=ipfwadm_core -c -o
ipfwadm_core.o ipfwadm_core.c
ipfwadm_core.c: In function `free_fw_chain':
ipfwadm_core.c:691: called object is not a function
ipfwadm_core.c: In function `insert_in_chain':
ipfwadm_core.c:735: called object is not a function
ipfwadm_core.c: In function `append_to_chain':
ipfwadm_core.c:786: called object is not a function
ipfwadm_core.c: In function `del_from_chain':
ipfwadm_core.c:861: called object is not a function
make[2]: *** [ipfwadm_core.o] Error 1
make[2]: Leaving directory
`/usr/src/linux-2.4.18-pre7/net/ipv4/netfilter'
make[1]: *** [_modsubdir_ipv4/netfilter] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.18-pre7/net'
make: *** [_mod_net] Error 2

Regards,
Stephan


2002-01-24 00:01:54

by Evgeniy Polyakov

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7: compile error

On Thu, 24 Jan 2002 00:46:45 +0100
Stephan von Krawczynski <[email protected]> wrote:

> "I am sorry, Dave. I'm afraid I can't do that":

> ipfwadm_core.o ipfwadm_core.c
> ipfwadm_core.c: In function `free_fw_chain':
> ipfwadm_core.c:691: called object is not a function
> ipfwadm_core.c: In function `insert_in_chain':
> ipfwadm_core.c:735: called object is not a function
> ipfwadm_core.c: In function `append_to_chain':
> ipfwadm_core.c:786: called object is not a function
> ipfwadm_core.c: In function `del_from_chain':
> ipfwadm_core.c:861: called object is not a function

I hope this patch will help you:

--- ./net/ipv4/netfilter/ipfwadm_core.c Thu Jan 24 02:57:54 2002
+++ ./net/ipv4/netfilter/ipfwadm_core.c~ Thu Jan 24 02:58:01 2002
@@ -688,7 +688,7 @@
ftmp = *chainptr;
*chainptr = ftmp->fw_next;
kfree(ftmp);
- MOD_DEC_USE_COUNT();
+ MOD_DEC_USE_COUNT;
}
restore_flags(flags);
}
@@ -732,7 +732,7 @@
ftmp->fw_next = *chainptr;
*chainptr=ftmp;
restore_flags(flags);
- MOD_INC_USE_COUNT();
+ MOD_INC_USE_COUNT;
return(0);
}

@@ -783,7 +783,7 @@
else
*chainptr=ftmp;
restore_flags(flags);
- MOD_INC_USE_COUNT();
+ MOD_INC_USE_COUNT;
return(0);
}

@@ -858,7 +858,7 @@
}
restore_flags(flags);
if (was_found) {
- MOD_DEC_USE_COUNT();
+ MOD_DEC_USE_COUNT;
return 0;
} else
return(EINVAL);



> Regards,
> Stephan

Evgeniy Polyakov ( s0mbre ).

2002-01-24 00:42:02

by Keith Owens

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7

Three generated files have crept into the patch. They need to be
deleted. rm drivers/sound/*_boot.h

2002-01-24 03:15:29

by Stephen Rothwell

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7

Hi all,

Just to keep the record straight ...

On Wed, 23 Jan 2002 19:55:46 -0200 (BRST)
Marcelo Tosatti <[email protected]> wrote:
>
> pre7:
>
> - APM fixes (Stephen Rothwell)

Actual work done by Thomas Hood, Andreas Steinmetz, Russell King,
myself and others.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

2002-01-24 08:57:51

by Philipp Matthias Hahn

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7

Hi!

On Wed, Jan 23, 2002 at 07:55:46PM -0200, Marcelo Tosatti wrote:
> pre7:
> - Netfilter update (Netfilter team)
net/ipv4/netfilter/ipt_{ah,esp,ULOG}.c are missing in the patch!
Fails on install.

BYtE
Philipp
--
/ / (_)__ __ ____ __ Philipp Hahn
/ /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ [email protected]

2002-01-24 20:22:30

by Stephan von Krawczynski

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7: compile error

On Thu, 24 Jan 2002 03:01:06 +0300
Evgeniy Polyakov <[email protected]> wrote:

> On Thu, 24 Jan 2002 00:46:45 +0100
> Stephan von Krawczynski <[email protected]> wrote:
>
> > "I am sorry, Dave. I'm afraid I can't do that":
>
> > ipfwadm_core.o ipfwadm_core.c
> > ipfwadm_core.c: In function `free_fw_chain':
> > ipfwadm_core.c:691: called object is not a function
> > ipfwadm_core.c: In function `insert_in_chain':
> > ipfwadm_core.c:735: called object is not a function
> > ipfwadm_core.c: In function `append_to_chain':
> > ipfwadm_core.c:786: called object is not a function
> > ipfwadm_core.c: In function `del_from_chain':
> > ipfwadm_core.c:861: called object is not a function
>
> I hope this patch will help you:

Yes, in principal, but unfortunately the white spaces were tilted
in your patch, so here is a corrected version for inclusion.

Thanks Evgeniy.


--- linux/net/ipv4/netfilter/ipfwadm_core.c~ Thu Jan 24 21:16:02 2002
+++ linux/net/ipv4/netfilter/ipfwadm_core.c Thu Jan 24 21:16:38 2002
@@ -688,7 +688,7 @@
ftmp = *chainptr;
*chainptr = ftmp->fw_next;
kfree(ftmp);
- MOD_DEC_USE_COUNT();
+ MOD_DEC_USE_COUNT;
}
restore_flags(flags);
}
@@ -732,7 +732,7 @@
ftmp->fw_next = *chainptr;
*chainptr=ftmp;
restore_flags(flags);
- MOD_INC_USE_COUNT();
+ MOD_INC_USE_COUNT;
return(0);
}

@@ -783,7 +783,7 @@
else
*chainptr=ftmp;
restore_flags(flags);
- MOD_INC_USE_COUNT();
+ MOD_INC_USE_COUNT;
return(0);
}

@@ -858,7 +858,7 @@
}
restore_flags(flags);
if (was_found) {
- MOD_DEC_USE_COUNT();
+ MOD_DEC_USE_COUNT;
return 0;
} else
return(EINVAL);

2002-01-24 21:01:01

by George Bonser

[permalink] [raw]
Subject: 2.4.18-pre7 cant find scsi disks

I can't boot pre7 but pre6 works every time. AIC7XXX controller with
a single drive.
It looks like it gets some kind of error when it is looking for disks.

Hard to get the message it prints out because it looks like it is
trying every possible LUN. The original message scrolls off and I cant
page back because new lines put me back to the current line.

pre7 is not a good thing. A pre6 dmesg reports the following on a
good boot:

SCSI subsystem driver Revision: 1.0
scsi0 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 6.2.4
<Adaptec aic7896/97 Ultra2 SCSI adapter>
aic7896/97: Ultra2 Wide Channel A, SCSI Id=7, 32/253 SCBs

scsi1 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 6.2.4
<Adaptec aic7896/97 Ultra2 SCSI adapter>
aic7896/97: Ultra2 Wide Channel A, SCSI Id=7, 32/253 SCBs

Vendor: SEAGATE Model: ST31840LW Rev: 0006
Type: Direct-Access ANSI SCSI revision: 03
(scsi0:A:0) 80.000MB/s transfers (40.000MHz, offset 63, 16bit)
Attached scsi disk sda at scsi0, channel 0, id 0, lun 0
Partition check:
sda: sda1 sda2 sda3


On the failed boot I get scsi0:0:0:0: Attempting to queue ABORT
message right after it posts the scsi0 and scsi1 controller info and
it looks like it just starts going from scsi0:0:0:0 to 0:0:1:0,
0:0:2:0, 0:0:3:0, etc looking for a disk.

2002-01-24 22:51:03

by Rasmus Andersen

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7

On Wed, Jan 23, 2002 at 07:55:46PM -0200, Marcelo Tosatti wrote:
>
> Hi,
>
> So here goes pre7.

Hi Marcelo.

This is a resend of a patch I sent you earlier, rediffed. Explanation
below. If you would prefer Rogier Wolff to send it, please let me
know.

---
The following patch makes drivers/char/generic_serial.c check the
return code of copy_{from,to}_user, coverts a cli/sti to
save_flags/cli/restore_flags and does some minor cleanup. It
also makes the rio_linux, serial_tx3912, sh-sci and sx drivers
propagate the copy_xxx_user return codes upwards.

The patch has been blessed by Rogier Wolff, the maintainer.
---


diff -uar linux-2418p7-clean/drivers/char/generic_serial.c linux-2418p7/drivers/char/generic_serial.c
--- linux-2418p7-clean/drivers/char/generic_serial.c Fri Sep 14 00:21:32 2001
+++ linux-2418p7/drivers/char/generic_serial.c Thu Jan 24 23:45:14 2002
@@ -143,7 +143,12 @@
/* Can't copy more? break out! */
if (c <= 0) break;
if (from_user)
- copy_from_user (port->xmit_buf + port->xmit_head, buf, c);
+ if (copy_from_user (port->xmit_buf + port->xmit_head,
+ buf, c)) {
+ up (& port->port_write_sem);
+ return -EFAULT;
+ }
+
else
memcpy (port->xmit_buf + port->xmit_head, buf, c);

@@ -214,8 +219,13 @@
while (1) {
c = count;

- /* This is safe because we "OWN" the "head". Noone else can
- change the "head": we own the port_write_sem. */
+ /* Note: This part can be done without
+ * interrupt routine protection since
+ * the interrupt routines may only modify
+ * shared variables in safe ways, in the worst
+ * case causing us to loop twice in the code
+ * below. See comments below. */
+
/* Don't overrun the end of the buffer */
t = SERIAL_XMIT_SIZE - port->xmit_head;
if (t < c) c = t;
@@ -506,7 +516,7 @@

void gs_shutdown_port (struct gs_port *port)
{
- long flags;
+ unsigned long flags;

func_enter();

@@ -589,6 +599,7 @@
int do_clocal = 0;
int CD;
struct tty_struct *tty;
+ unsigned long flags;

func_enter ();

@@ -604,7 +615,7 @@
* until it's done, and then try again.
*/
if (tty_hung_up_p(filp) || port->flags & ASYNC_CLOSING) {
- interruptible_sleep_on(&port->close_wait);
+ interruptible_sleep_on(&port->close_wait);
if (port->flags & ASYNC_HUP_NOTIFY)
return -EAGAIN;
else
@@ -668,10 +679,11 @@
add_wait_queue(&port->open_wait, &wait);

gs_dprintk (GS_DEBUG_BTR, "after add waitq.\n");
+ save_flags(flags);
cli();
if (!tty_hung_up_p(filp))
port->count--;
- sti();
+ restore_flags(flags);
port->blocked_open++;
while (1) {
CD = port->rd->get_CD (port);
@@ -1003,7 +1015,8 @@
{
struct serial_struct sio;

- copy_from_user(&sio, sp, sizeof(struct serial_struct));
+ if (copy_from_user(&sio, sp, sizeof(struct serial_struct)))
+ return(-EFAULT);

if (!capable(CAP_SYS_ADMIN)) {
if ((sio.baud_base != port->baud_base) ||
@@ -1033,7 +1046,7 @@
* Generate the serial struct info.
*/

-void gs_getserial(struct gs_port *port, struct serial_struct *sp)
+int gs_getserial(struct gs_port *port, struct serial_struct *sp)
{
struct serial_struct sio;

@@ -1055,7 +1068,10 @@
if (port->rd->getserial)
port->rd->getserial (port, &sio);

- copy_to_user(sp, &sio, sizeof(struct serial_struct));
+ if (copy_to_user(sp, &sio, sizeof(struct serial_struct)))
+ return -EFAULT;
+ return 0;
+
}


diff -uar linux-2418p7-clean/drivers/char/rio/rio_linux.c linux-2418p7/drivers/char/rio/rio_linux.c
--- linux-2418p7-clean/drivers/char/rio/rio_linux.c Thu Oct 25 22:53:47 2001
+++ linux-2418p7/drivers/char/rio/rio_linux.c Thu Jan 24 23:45:14 2002
@@ -742,7 +742,7 @@
case TIOCGSERIAL:
if ((rc = verify_area(VERIFY_WRITE, (void *) arg,
sizeof(struct serial_struct))) == 0)
- gs_getserial(&PortP->gs, (struct serial_struct *) arg);
+ rc = gs_getserial(&PortP->gs, (struct serial_struct *) arg);
break;
case TCSBRK:
if ( PortP->State & RIO_DELETED ) {
diff -uar linux-2418p7-clean/drivers/char/serial_tx3912.c linux-2418p7/drivers/char/serial_tx3912.c
--- linux-2418p7-clean/drivers/char/serial_tx3912.c Fri Nov 9 23:01:21 2001
+++ linux-2418p7/drivers/char/serial_tx3912.c Thu Jan 24 23:45:14 2002
@@ -673,7 +673,7 @@
case TIOCGSERIAL:
if ((rc = verify_area(VERIFY_WRITE, (void *) arg,
sizeof(struct serial_struct))) == 0)
- gs_getserial(&port->gs, (struct serial_struct *) arg);
+ rc = gs_getserial(&port->gs, (struct serial_struct *) arg);
break;
case TIOCSSERIAL:
if ((rc = verify_area(VERIFY_READ, (void *) arg,
diff -uar linux-2418p7-clean/drivers/char/sh-sci.c linux-2418p7/drivers/char/sh-sci.c
--- linux-2418p7-clean/drivers/char/sh-sci.c Mon Oct 15 22:36:48 2001
+++ linux-2418p7/drivers/char/sh-sci.c Thu Jan 24 23:45:14 2002
@@ -919,7 +919,7 @@
case TIOCGSERIAL:
if ((rc = verify_area(VERIFY_WRITE, (void *) arg,
sizeof(struct serial_struct))) == 0)
- gs_getserial(&port->gs, (struct serial_struct *) arg);
+ rc = gs_getserial(&port->gs, (struct serial_struct *) arg);
break;
case TIOCSSERIAL:
if ((rc = verify_area(VERIFY_READ, (void *) arg,
diff -uar linux-2418p7-clean/drivers/char/sx.c linux-2418p7/drivers/char/sx.c
--- linux-2418p7-clean/drivers/char/sx.c Thu Jan 24 23:37:09 2002
+++ linux-2418p7/drivers/char/sx.c Thu Jan 24 23:45:14 2002
@@ -1817,7 +1817,7 @@
case TIOCGSERIAL:
if ((rc = verify_area(VERIFY_WRITE, (void *) arg,
sizeof(struct serial_struct))) == 0)
- gs_getserial(&port->gs, (struct serial_struct *) arg);
+ rc = gs_getserial(&port->gs, (struct serial_struct *) arg);
break;
case TIOCSSERIAL:
if ((rc = verify_area(VERIFY_READ, (void *) arg,
diff -uar linux-2418p7-clean/include/linux/generic_serial.h linux-2418p7/include/linux/generic_serial.h
--- linux-2418p7-clean/include/linux/generic_serial.h Fri Sep 7 18:28:38 2001
+++ linux-2418p7/include/linux/generic_serial.h Thu Jan 24 23:45:14 2002
@@ -12,9 +12,6 @@
#ifndef GENERIC_SERIAL_H
#define GENERIC_SERIAL_H

-
-
-
struct real_driver {
void (*disable_tx_interrupts) (void *);
void (*enable_tx_interrupts) (void *);
@@ -98,7 +95,7 @@
struct termios * old_termios);
int gs_init_port(struct gs_port *port);
int gs_setserial(struct gs_port *port, struct serial_struct *sp);
-void gs_getserial(struct gs_port *port, struct serial_struct *sp);
+int gs_getserial(struct gs_port *port, struct serial_struct *sp);
void gs_got_break(struct gs_port *port);

extern int gs_debug;

--
Regards,
Rasmus([email protected])

2002-01-25 07:41:28

by Harald Welte

[permalink] [raw]
Subject: Re: Linux 2.4.18-pre7

On Thu, Jan 24, 2002 at 09:56:49AM +0100, Philipp Matthias Hahn wrote:
> Hi!
>
> On Wed, Jan 23, 2002 at 07:55:46PM -0200, Marcelo Tosatti wrote:
> > pre7:
> > - Netfilter update (Netfilter team)
>
> net/ipv4/netfilter/ipt_{ah,esp,ULOG}.c are missing in the patch!
> Fails on install.

The files have been submitted but somehow didn't appear in the final
kernel tree. David Miller and Marcelo will take care of it in the
next prerelease.

If you need the features until then, use a kernel <= 2.4.18-pre6 and
patch-o-matic from the latest iptables package or netfilter CVS.

> BYtE
> Philipp

--
Live long and prosper
- Harald Welte / [email protected] http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M-
V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*)

2002-01-25 07:41:45

by Harald Welte

[permalink] [raw]
Subject: netfilter changes in 2.4.18-pre7 (was Re: Linux 2.4.18-pre7)

On Thu, Jan 24, 2002 at 10:19:43AM +1100, CaT wrote:
> On Wed, Jan 23, 2002 at 07:55:46PM -0200, Marcelo Tosatti wrote:
> > - Netfilter update (Netfilter team)
>
> This appears to include the fix for the crash bug I reported earlier
> involving ipchains compatability and redirects appears to be in this. :)

Yes. The netfilter changes as of 2.4.17-pre7 have been:

o have mangle teable attach to all five hooks
(Brad Chapman & me)
o new match for SPI field in AH/ESP ipsec headers (broken1)
(Yon Uriarte)
o new ULOG target for high performance userspace packet logging (broken1)
(me)
o fix skb_headroom reallocation after destination change (your bug)
(Rusty Russell, Marc Boucher & me)
o fix REDIRECT handling of artificial TCP RST's generated by REJECT
(Marc Boucher)
o fix debugging code for ip_fw_compat.c
(Rusty Russell)
o fix bug when using REDIRECT and no IP address is attached to
an interface
(Lennert Buytenhek)
o add ip_queue (and QUEUE target) support for IPv6
(Fernando Anton & James Morris)
o fix printing of inner ICMP packet (if icmp in icmp errmsg) in LOG target
(Jozsef Kadlecsik)
o fix typo in errormessage of ipv6 MARK target
(Dave Jones)
o increase module usage count as soon as there are rules in iptables
(me)
o increase module usage count as soon as there are rules in ipchains
(me)
o increase module usage count as soon as there are rules in ipfwadm (broken2)
(Rusty Russell)


broken1: broken because the final kernel tree was strangely missing two
.c files which had been inside the patch
(davem and marcelo taking care of this)

broken2: broken because I was too lazy. Patch has appeared on lkml and is
submitted for kernel inclusion.


> Woo. :)

--
Live long and prosper
- Harald Welte / [email protected] http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M-
V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*)