2022-10-24 17:44:35

by Job Noorman

[permalink] [raw]
Subject: [PATCH v6 3/3] arm64: dts: qcom: sdm632: fairphone-fp3: add touchscreen

Add Himax hx83112b touchscreen to the FP3 DT.

Signed-off-by: Job Noorman <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 891e314bc782..2920504461d3 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -49,6 +49,20 @@ &hsusb_phy {
vdda-phy-dpdm-supply = <&pm8953_l13>;
};

+&i2c_3 {
+ status = "okay";
+
+ touchscreen@48 {
+ compatible = "himax,hx83112b";
+ reg = <0x48>;
+ interrupt-parent = <&tlmm>;
+ interrupts = <65 IRQ_TYPE_LEVEL_LOW>;
+ touchscreen-size-x = <1080>;
+ touchscreen-size-y = <2160>;
+ reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
+ };
+};
+
&pm8953_resin {
status = "okay";
linux,code = <KEY_VOLUMEDOWN>;
--
2.38.1


2022-10-28 21:56:53

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: sdm632: fairphone-fp3: add touchscreen

On Mon, Oct 24, 2022 at 03:59:59PM +0200, Job Noorman wrote:
> Add Himax hx83112b touchscreen to the FP3 DT.
>
> Signed-off-by: Job Noorman <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Please include at least all the mailing lists as Cc on all your patches
in the series - I'm not subscribed to linux-input, so I don't have patch
1 or patch 2 in my inbox.

Thanks,
Bjorn

> ---
> arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> index 891e314bc782..2920504461d3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> @@ -49,6 +49,20 @@ &hsusb_phy {
> vdda-phy-dpdm-supply = <&pm8953_l13>;
> };
>
> +&i2c_3 {
> + status = "okay";
> +
> + touchscreen@48 {
> + compatible = "himax,hx83112b";
> + reg = <0x48>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <65 IRQ_TYPE_LEVEL_LOW>;
> + touchscreen-size-x = <1080>;
> + touchscreen-size-y = <2160>;
> + reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
> + };
> +};
> +
> &pm8953_resin {
> status = "okay";
> linux,code = <KEY_VOLUMEDOWN>;
> --
> 2.38.1
>

2022-10-29 11:42:22

by Job Noorman

[permalink] [raw]
Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: sdm632: fairphone-fp3: add touchscreen

Hi Bjorn,

On Fri Oct 28, 2022 at 11:44 PM CEST, Bjorn Andersson wrote:
> Please include at least all the mailing lists as Cc on all your patches
> in the series - I'm not subscribed to linux-input, so I don't have patch
> 1 or patch 2 in my inbox.

No problem, I will resend with all mailing lists in Cc for all patches!

Since this is the first patch series I submit to the kernel, I wonder if
you could elaborate a bit on what the correct process is to select
recipients?

My current git send-email workflow is as follows:
- --to-cmd="get_maintainer.pl ... --nol"
- --cc-cmd="get_maintainer.pl ... --nom"
- Cover letter: the same commands but run on all patches in the series

If I understand you correctly, your advice would be to change only the
second part of this workflow to also run the command on _all_ patches in
the series. Is this correct?

Best regards,
Job