2022-10-30 07:34:44

by Marijn Suijten

Subject: [PATCH 04/10] arm64: dts: qcom: pm6350: Include header for KEY_POWER

Make pm6350.dtsi self-contained by including input.h, needed for the
KEY_POWER constant used to define the power key.

Fixes: d8a3c775d7cd ("arm64: dts: qcom: Add PM6350 PMIC")
Signed-off-by: Marijn Suijten <[email protected]>
---
arch/arm64/boot/dts/qcom/pm6350.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/pm6350.dtsi b/arch/arm64/boot/dts/qcom/pm6350.dtsi
index 18c14257e2c1..111f4c1c56ae 100644
--- a/arch/arm64/boot/dts/qcom/pm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm6350.dtsi
@@ -3,6 +3,7 @@
* Copyright (c) 2021, Luca Weiss <[email protected]>
*/

+#include <dt-bindings/input/input.h>
#include <dt-bindings/spmi/spmi.h>

&spmi_bus {
--
2.38.1

2022-10-31 09:31:27

by Luca Weiss

Subject: Re: [PATCH 04/10] arm64: dts: qcom: pm6350: Include header for KEY_POWER

On Sun Oct 30, 2022 at 8:32 AM CET, Marijn Suijten wrote:
> Make pm6350.dtsi self-contained by including input.h, needed for the
> KEY_POWER constant used to define the power key.
>
> Fixes: d8a3c775d7cd ("arm64: dts: qcom: Add PM6350 PMIC")
> Signed-off-by: Marijn Suijten <[email protected]>

Thanks for fixing!

Reviewed-by: Luca Weiss <[email protected]>

Regards
Luca

> ---
> arch/arm64/boot/dts/qcom/pm6350.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm6350.dtsi b/arch/arm64/boot/dts/qcom/pm6350.dtsi
> index 18c14257e2c1..111f4c1c56ae 100644
> --- a/arch/arm64/boot/dts/qcom/pm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm6350.dtsi
> @@ -3,6 +3,7 @@
> * Copyright (c) 2021, Luca Weiss <[email protected]>
> */
>
> +#include <dt-bindings/input/input.h>
> #include <dt-bindings/spmi/spmi.h>
>
> &spmi_bus {
> --
> 2.38.1

2022-10-31 21:45:40

by Konrad Dybcio

Subject: Re: [PATCH 04/10] arm64: dts: qcom: pm6350: Include header for KEY_POWER

On 30.10.2022 08:32, Marijn Suijten wrote:
> Make pm6350.dtsi self-contained by including input.h, needed for the
> KEY_POWER constant used to define the power key.
>
> Fixes: d8a3c775d7cd ("arm64: dts: qcom: Add PM6350 PMIC")
> Signed-off-by: Marijn Suijten <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/pm6350.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm6350.dtsi b/arch/arm64/boot/dts/qcom/pm6350.dtsi
> index 18c14257e2c1..111f4c1c56ae 100644
> --- a/arch/arm64/boot/dts/qcom/pm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm6350.dtsi
> @@ -3,6 +3,7 @@
> * Copyright (c) 2021, Luca Weiss <[email protected]>
> */
>
> +#include <dt-bindings/input/input.h>
> #include <dt-bindings/spmi/spmi.h>
>
> &spmi_bus {