New parameters added to Cadence ethernet controller DT binding
for USXGMII interface.
Signed-off-by: Parshuram Thombare <[email protected]>
---
Documentation/devicetree/bindings/net/macb.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 9c5e94482b5f..cd79ec9dddfb 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -25,6 +25,10 @@ Required properties:
Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
Optional elements: 'tsu_clk'
- clocks: Phandles to input clocks.
+- serdes-rate External serdes rate.Mandatory for USXGMII mode.
+ 0 - 5G
+ 1 - 10G
+- fixed-speed Speed for fixed mode UXSGMII interface based link
The MAC address will be determined using the optional properties
defined in ethernet.txt.
--
2.17.1
On Sun, Jun 16, 2019 at 12:49:39AM +0100, Parshuram Thombare wrote:
> New parameters added to Cadence ethernet controller DT binding
> for USXGMII interface.
>
> Signed-off-by: Parshuram Thombare <[email protected]>
> ---
> Documentation/devicetree/bindings/net/macb.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 9c5e94482b5f..cd79ec9dddfb 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -25,6 +25,10 @@ Required properties:
> Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
> +- serdes-rate External serdes rate.Mandatory for USXGMII mode.
> + 0 - 5G
> + 1 - 10G
Please use the values 5 and 10, not 0 and 1. This also needs a vendor
prefix.
Andrew
>On Sun, Jun 16, 2019 at 12:49:39AM +0100, Parshuram Thombare wrote:
>> New parameters added to Cadence ethernet controller DT binding for
>> USXGMII interface.
>>
>> Signed-off-by: Parshuram Thombare <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/macb.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/macb.txt
>> b/Documentation/devicetree/bindings/net/macb.txt
>> index 9c5e94482b5f..cd79ec9dddfb 100644
>> --- a/Documentation/devicetree/bindings/net/macb.txt
>> +++ b/Documentation/devicetree/bindings/net/macb.txt
>> @@ -25,6 +25,10 @@ Required properties:
>> Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
>> Optional elements: 'tsu_clk'
>> - clocks: Phandles to input clocks.
>> +- serdes-rate External serdes rate.Mandatory for USXGMII mode.
>> + 0 - 5G
>> + 1 - 10G
>
Ok
>Please use the values 5 and 10, not 0 and 1. This also needs a vendor prefix.
>
> Andrew
Regards,
Parshuram Thombare
New parameters added to Cadence ethernet controller DT binding
for USXGMII interface.
Signed-off-by: Parshuram Thombare <[email protected]>
---
Documentation/devicetree/bindings/net/macb.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 9c5e94482b5f..b80d58ed1650 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -25,6 +25,9 @@ Required properties:
Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
Optional elements: 'tsu_clk'
- clocks: Phandles to input clocks.
+- serdes-rate External serdes rate.Mandatory for USXGMII mode.
+ 5 - 5G
+ 10 - 10G
The MAC address will be determined using the optional properties
defined in ethernet.txt.
--
2.17.1
On 6/18/19 11:45 AM, Parshuram Thombare wrote:
> New parameters added to Cadence ethernet controller DT binding
> for USXGMII interface.
Please don't resubmit individual patches as replies to your previous
ones, re-submitting the entire patch series, see this netdev-FAQ section
for details:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n134
>
> Signed-off-by: Parshuram Thombare <[email protected]>
> ---
> Documentation/devicetree/bindings/net/macb.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 9c5e94482b5f..b80d58ed1650 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -25,6 +25,9 @@ Required properties:
> Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
> +- serdes-rate External serdes rate.Mandatory for USXGMII mode.
> + 5 - 5G
> + 10 - 10G
There should be an unit specifier in that property, something like:
serdes-rate-gbps
can't we somehow automatically detect that?
>
> The MAC address will be determined using the optional properties
> defined in ethernet.txt.
>
--
Florian
Hi Florian,
>Please don't resubmit individual patches as replies to your previous
>ones, re-submitting the entire patch series, see this netdev-FAQ section
>for details:
I will resubmit entire patch series separately.
>
>> +- serdes-rate External serdes rate.Mandatory for USXGMII mode.
>
>> + 5 - 5G
>
>> + 10 - 10G
>
>
>
>There should be an unit specifier in that property, something like:
>serdes-rate-gbps
>can't we somehow automatically detect that?
Ok, sure. I will add unit specifier to property name.
No, currently HW don’t have way to auto detect external serdes rate.
Regards,
Parshuram Thombare