We don't actually care about connection_mutex here anymore, so let's get
rid of the comment mentioning it in this function's kdocs.
Signed-off-by: Lyude Paul <[email protected]>
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index d6e595b95f07..9f96132a5d74 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -5458,8 +5458,7 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
*
* This function wraps drm_atomic_get_priv_obj_state() passing in the MST atomic
* state vtable so that the private object state returned is that of a MST
- * topology object. Also, drm_atomic_get_private_obj_state() expects the caller
- * to care of the locking, so warn if don't hold the connection_mutex.
+ * topology object.
*
* RETURNS:
*
--
2.35.3
[Public]
Hi Lyude,
Feel free to add
Reviewed-by: Wayne Lin <[email protected]>
> -----Original Message-----
> From: Lyude Paul <[email protected]>
> Sent: Friday, June 3, 2022 4:18 AM
> To: [email protected]
> Cc: David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Thomas
> Zimmermann <[email protected]>; Lin, Wayne
> <[email protected]>; Jani Nikula <[email protected]>; Lakha,
> Bhawanpreet <[email protected]>; Rajkumar Subbiah
> <[email protected]>; open list <[email protected]>
> Subject: [PATCH 3/3] drm/dp_mst: Get rid of old comment in
> drm_atomic_get_mst_topology_state docs
>
> We don't actually care about connection_mutex here anymore, so let's get
> rid of the comment mentioning it in this function's kdocs.
>
> Signed-off-by: Lyude Paul <[email protected]>
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index d6e595b95f07..9f96132a5d74 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5458,8 +5458,7 @@
> EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
> *
> * This function wraps drm_atomic_get_priv_obj_state() passing in the MST
> atomic
> * state vtable so that the private object state returned is that of a MST
> - * topology object. Also, drm_atomic_get_private_obj_state() expects the
> caller
> - * to care of the locking, so warn if don't hold the connection_mutex.
> + * topology object.
> *
> * RETURNS:
> *
> --
> 2.35.3
--
Regards,
Wayne Lin
Thanks! Will push these two patches upstream
On Mon, 2022-06-13 at 09:59 +0000, Lin, Wayne wrote:
> [Public]
>
> Hi Lyude,
>
> Feel free to add
> Reviewed-by: Wayne Lin <[email protected]>
>
> > -----Original Message-----
> > From: Lyude Paul <[email protected]>
> > Sent: Friday, June 3, 2022 4:18 AM
> > To: [email protected]
> > Cc: David Airlie <[email protected]>; Daniel Vetter <[email protected]>;
> > Thomas
> > Zimmermann <[email protected]>; Lin, Wayne
> > <[email protected]>; Jani Nikula <[email protected]>; Lakha,
> > Bhawanpreet <[email protected]>; Rajkumar Subbiah
> > <[email protected]>; open list <[email protected]>
> > Subject: [PATCH 3/3] drm/dp_mst: Get rid of old comment in
> > drm_atomic_get_mst_topology_state docs
> >
> > We don't actually care about connection_mutex here anymore, so let's get
> > rid of the comment mentioning it in this function's kdocs.
> >
> > Signed-off-by: Lyude Paul <[email protected]>
> > ---
> > drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > index d6e595b95f07..9f96132a5d74 100644
> > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > @@ -5458,8 +5458,7 @@
> > EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
> > *
> > * This function wraps drm_atomic_get_priv_obj_state() passing in the MST
> > atomic
> > * state vtable so that the private object state returned is that of a
> > MST
> > - * topology object. Also, drm_atomic_get_private_obj_state() expects the
> > caller
> > - * to care of the locking, so warn if don't hold the connection_mutex.
> > + * topology object.
> > *
> > * RETURNS:
> > *
> > --
> > 2.35.3
>
> --
> Regards,
> Wayne Lin
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat