2021-04-01 17:49:29

by Randy Dunlap

[permalink] [raw]
Subject: Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

On 4/1/21 5:33 AM, Kostya Porotchkin wrote:
> Hi, Randy,
>
>> -----Original Message-----
>> From: Randy Dunlap <[email protected]>
>> Sent: Wednesday, March 31, 2021 18:28
>> To: Stephen Rothwell <[email protected]>; Linux Next Mailing List <linux-
>> [email protected]>
>> Cc: Linux Kernel Mailing List <[email protected]>; Kostya
>> Porotchkin <[email protected]>; [email protected]
>> Subject: [EXT] Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-
>> cp110-utmi.o)
>>
>
>
>>
>> on i386:
>>
>> ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function
>> `mvebu_cp110_utmi_phy_probe':
>> phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to
>> `of_usb_get_dr_mode_by_phy'
>>
> [KP] This driver depends on ARCH_MVEBU (arm64).
> How it happens that it is included in i386 builds?

Due to COMPILE_TEST:

config PHY_MVEBU_CP110_UTMI
tristate "Marvell CP110 UTMI driver"
depends on ARCH_MVEBU || COMPILE_TEST
depends on OF
select GENERIC_PHY


>
> Regards
> Kosta
>>
>> Full randconfig file is attached.
>>
>> --


--
~Randy


2021-04-01 17:53:09

by Kostya Porotchkin

[permalink] [raw]
Subject: RE: Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

Hi, Randy,

> -----Original Message-----
> From: Randy Dunlap <[email protected]>
> Sent: Wednesday, March 31, 2021 18:28
> To: Stephen Rothwell <[email protected]>; Linux Next Mailing List <linux-
> [email protected]>
> Cc: Linux Kernel Mailing List <[email protected]>; Kostya
> Porotchkin <[email protected]>; [email protected]
> Subject: [EXT] Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-
> cp110-utmi.o)
>


>
> on i386:
>
> ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function
> `mvebu_cp110_utmi_phy_probe':
> phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to
> `of_usb_get_dr_mode_by_phy'
>
[KP] This driver depends on ARCH_MVEBU (arm64).
How it happens that it is included in i386 builds?

Regards
Kosta
>
> Full randconfig file is attached.
>
> --
> ~Randy
> Reported-by: Randy Dunlap <[email protected]>

2021-04-01 18:07:24

by Randy Dunlap

[permalink] [raw]
Subject: Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

On 4/1/21 9:29 AM, Randy Dunlap wrote:
> On 4/1/21 5:33 AM, Kostya Porotchkin wrote:
>> Hi, Randy,
>>
>>> -----Original Message-----
>>> From: Randy Dunlap <[email protected]>
>>> Sent: Wednesday, March 31, 2021 18:28
>>> To: Stephen Rothwell <[email protected]>; Linux Next Mailing List <linux-
>>> [email protected]>
>>> Cc: Linux Kernel Mailing List <[email protected]>; Kostya
>>> Porotchkin <[email protected]>; [email protected]
>>> Subject: [EXT] Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-
>>> cp110-utmi.o)
>>>
>>
>>
>>>
>>> on i386:
>>>
>>> ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function
>>> `mvebu_cp110_utmi_phy_probe':
>>> phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to
>>> `of_usb_get_dr_mode_by_phy'
>>>
>> [KP] This driver depends on ARCH_MVEBU (arm64).
>> How it happens that it is included in i386 builds?
>
> Due to COMPILE_TEST:
>
> config PHY_MVEBU_CP110_UTMI
> tristate "Marvell CP110 UTMI driver"
> depends on ARCH_MVEBU || COMPILE_TEST
> depends on OF
> select GENERIC_PHY
>
>
>>
>> Regards
>> Kosta
>>>
>>> Full randconfig file is attached.
>>>
>>> --

This happens because CONFIG_USB is not set but the missing
function is only compiled if CONFIG_USB_COMMON is set.

--
~Randy