2023-02-13 04:27:28

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the uml tree

Hi all,

After merging the uml tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/rust/arch-support.rst:20: WARNING: Blank line required after table.

Introduced by commit

0438aadfa69a ("rust: arch/um: Add support for CONFIG_RUST under x86_64 UML")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2023-02-13 09:00:06

by Bagas Sanjaya

[permalink] [raw]
Subject: [PATCH] Documentation: rust: Fix arch support table

Stephen Rothwell reported htmldocs warning when merging uml tree:

Documentation/rust/arch-support.rst:20: WARNING: Blank line required after table.

Fix the arch support table by removing extraneous simple table marker.

Link: https://lore.kernel.org/linux-next/[email protected]/
Fixes: 0438aadfa69a34 ("rust: arch/um: Add support for CONFIG_RUST under x86_64 UML")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Bagas Sanjaya <[email protected]>
---
Documentation/rust/arch-support.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/rust/arch-support.rst b/Documentation/rust/arch-support.rst
index a526ca1c688be6..ed7f4f5b3cf157 100644
--- a/Documentation/rust/arch-support.rst
+++ b/Documentation/rust/arch-support.rst
@@ -16,6 +16,6 @@ support corresponds to ``S`` values in the ``MAINTAINERS`` file.
Architecture Level of support Constraints
============ ================ ==============================================
``x86`` Maintained ``x86_64`` only.
-============ ================ ==============================================
``um`` Maintained ``x86_64`` only.
============ ================ ==============================================
+

base-commit: 990627acb87c5f6d502fa71baf7b985b8a4bf248
--
An old man doll... just what I always wanted! - Clara


2023-02-13 09:11:54

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH] Documentation: rust: Fix arch support table

----- Ursprüngliche Mail -----
> Von: "Bagas Sanjaya" <[email protected]>
> Stephen Rothwell reported htmldocs warning when merging uml tree:
>
> Documentation/rust/arch-support.rst:20: WARNING: Blank line required after
> table.
>
> Fix the arch support table by removing extraneous simple table marker.
>
> Link:
> https://lore.kernel.org/linux-next/[email protected]/
> Fixes: 0438aadfa69a34 ("rust: arch/um: Add support for CONFIG_RUST under x86_64
> UML")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Bagas Sanjaya <[email protected]>
> ---
> Documentation/rust/arch-support.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/rust/arch-support.rst
> b/Documentation/rust/arch-support.rst
> index a526ca1c688be6..ed7f4f5b3cf157 100644
> --- a/Documentation/rust/arch-support.rst
> +++ b/Documentation/rust/arch-support.rst
> @@ -16,6 +16,6 @@ support corresponds to ``S`` values in the ``MAINTAINERS``
> file.
> Architecture Level of support Constraints
> ============ ================ ==============================================
> ``x86`` Maintained ``x86_64`` only.
> -============ ================ ==============================================
> ``um`` Maintained ``x86_64`` only.
> ============ ================ ==============================================
> +

Applied to linux-um next. :-)

Thanks,
//richard

2023-02-13 09:47:07

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH] Documentation: rust: Fix arch support table

On Mon, Feb 13, 2023 at 10:11 AM Richard Weinberger <[email protected]> wrote:
>
> Applied to linux-um next. :-)

Ah, I didn't notice you picked the series (I think there was no
message) -- thanks Richard!

Since it is still unsorted, I am taking the chance to add a "good
first issue" for that:
https://github.com/Rust-for-Linux/linux/issues/965

Cheers,
Miguel

2023-02-14 04:21:25

by David Gow

[permalink] [raw]
Subject: Re: [PATCH] Documentation: rust: Fix arch support table

On Mon, 13 Feb 2023 at 17:00, Bagas Sanjaya <[email protected]> wrote:
>
> Stephen Rothwell reported htmldocs warning when merging uml tree:
>
> Documentation/rust/arch-support.rst:20: WARNING: Blank line required after table.
>
> Fix the arch support table by removing extraneous simple table marker.
>
> Link: https://lore.kernel.org/linux-next/[email protected]/
> Fixes: 0438aadfa69a34 ("rust: arch/um: Add support for CONFIG_RUST under x86_64 UML")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Bagas Sanjaya <[email protected]>
> ---

Thanks for fixing this! I think I need to look into my sphinx version,
as this isn't the only warning it hasn't picked up...

Reviewed-by: David Gow <[email protected]>

(And, as Miguel notes, next time we update this table, we should put
these in alphabetical order...)

Cheers,
-- David

> Documentation/rust/arch-support.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/rust/arch-support.rst b/Documentation/rust/arch-support.rst
> index a526ca1c688be6..ed7f4f5b3cf157 100644
> --- a/Documentation/rust/arch-support.rst
> +++ b/Documentation/rust/arch-support.rst
> @@ -16,6 +16,6 @@ support corresponds to ``S`` values in the ``MAINTAINERS`` file.
> Architecture Level of support Constraints
> ============ ================ ==============================================
> ``x86`` Maintained ``x86_64`` only.
> -============ ================ ==============================================
> ``um`` Maintained ``x86_64`` only.
> ============ ================ ==============================================
> +
>
> base-commit: 990627acb87c5f6d502fa71baf7b985b8a4bf248
> --
> An old man doll... just what I always wanted! - Clara
>


Attachments:
smime.p7s (3.91 kB)
S/MIME Cryptographic Signature

2023-02-15 22:32:00

by Vincenzo Palazzo

[permalink] [raw]
Subject: Re: [PATCH] Documentation: rust: Fix arch support table

> Stephen Rothwell reported htmldocs warning when merging uml tree:
>
> Documentation/rust/arch-support.rst:20: WARNING: Blank line required after table.
>
> Fix the arch support table by removing extraneous simple table marker.
>
> Link: https://lore.kernel.org/linux-next/[email protected]/
> Fixes: 0438aadfa69a34 ("rust: arch/um: Add support for CONFIG_RUST under x86_64 UML")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Bagas Sanjaya <[email protected]>
> ---

Reviewed-by: Vincenzo Palazzo <[email protected]>