2017-06-27 21:18:39

by Quytelda Kahja

Subject: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.

Signed-off-by: Quytelda Kahja <[email protected]>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd19ddd..1c6dc3a3e64a 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device *dev)
err_debugfs_dir:
debugfs_remove_recursive(dev->debugfs_dir);
kfree(hdr_info);
- dev_err(&dev->device, "visorbus_create_instance failed: %d\n", err);
+ dev_err(&dev->device, "%s failed: %d\n", __func__, err);
return err;
}

--
2.13.2

2017-06-28 02:33:16

by Kershner, David A

Subject: RE: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.

> -----Original Message-----
> From: Quytelda Kahja [mailto:[email protected]]
> Sent: Tuesday, June 27, 2017 5:18 PM
> To: Kershner, David A <[email protected]>;
> [email protected]
> Cc: [email protected]; [email protected]; Quytelda
> Kahja <[email protected]>
> Subject: [PATCH] Replace the literal function name
> "visorbus_create_instance" with the format specifier "%s" so it can be
> dynamically filled by the __func__ macro.

I think the subject line got lost somehow, and should this have been a v2?

Subject line should start with staging: unisys: visorbus: preferably.

David Kershner

>
> Signed-off-by: Quytelda Kahja <[email protected]>
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd19ddd..1c6dc3a3e64a 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device
> *dev)
> err_debugfs_dir:
> debugfs_remove_recursive(dev->debugfs_dir);
> kfree(hdr_info);
> - dev_err(&dev->device, "visorbus_create_instance failed: %d\n",
> err);
> + dev_err(&dev->device, "%s failed: %d\n", __func__, err);
> return err;
> }
>
> --
> 2.13.2