2017-06-23 06:31:54

by Arvind Yadav

Subject: [PATCH] staging: unisys: visorbus: constify visorchipset_parahotplug_group

File size before:
text data bss dec hex filename
11058 816 24 11898 2e7a drivers/staging/unisys/visorbus/visorchipset.o

File size After adding 'const':
text data bss dec hex filename
11122 752 24 11898 2e7a drivers/staging/unisys/visorbus/visorchipset.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 4cfd0fa..5a499fa 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1151,7 +1151,7 @@ static ssize_t deviceenabled_store(struct device *dev,
NULL
};

-static struct attribute_group visorchipset_parahotplug_group = {
+static const struct attribute_group visorchipset_parahotplug_group = {
.name = "parahotplug",
.attrs = visorchipset_parahotplug_attrs
};
--
1.9.1

2017-06-27 17:06:10

by Kershner, David A

Subject: RE: [PATCH] staging: unisys: visorbus: constify visorchipset_parahotplug_group

> -----Original Message-----
> From: devel [mailto:[email protected]] On
> Behalf Of Arvind Yadav
> Sent: Friday, June 23, 2017 2:31 AM
> To: [email protected]; Sell, Timothy C
> <[email protected]>; Wadgaonkar, Sameer Laxmikant
> <[email protected]>; [email protected]
> Cc: [email protected]; *S-Par-Maintainer
> <[email protected]>; [email protected]
> Subject: [PATCH] staging: unisys: visorbus: constify
> visorchipset_parahotplug_group
>
> File size before:
> text data bss dec hex filename
> 11058 816 24 11898 2e7a
> drivers/staging/unisys/visorbus/visorchipset.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 11122 752 24 11898 2e7a
> drivers/staging/unisys/visorbus/visorchipset.o
>
> Signed-off-by: Arvind Yadav <[email protected]>
Acked-by: David Kershner <[email protected]>

> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
> b/drivers/staging/unisys/visorbus/visorchipset.c
> index 4cfd0fa..5a499fa 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1151,7 +1151,7 @@ static ssize_t deviceenabled_store(struct device
> *dev,
> NULL
> };
>
> -static struct attribute_group visorchipset_parahotplug_group = {
> +static const struct attribute_group visorchipset_parahotplug_group = {
> .name = "parahotplug",
> .attrs = visorchipset_parahotplug_attrs
> };
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel