2022-07-20 18:20:36

by Christophe JAILLET

Subject: [PATCH 2/2] scsi: hpsa: Simplify {clear|set}_bit() parameters

{clear|set}_bit() can take an almost arbitrarily large bit number, so there
is no need to manually compute addresses. This is just redundant.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/scsi/hpsa.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 0612ca681200..f8e832b1bc46 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6233,8 +6233,7 @@ static struct CommandList *cmd_alloc(struct ctlr_info *h)
offset = (i + 1) % HPSA_NRESERVED_CMDS;
continue;
}
- set_bit(i & (BITS_PER_LONG - 1),
- h->cmd_pool_bits + (i / BITS_PER_LONG));
+ set_bit(i, h->cmd_pool_bits);
break; /* it's ours now. */
}
hpsa_cmd_partial_init(h, i, c);
@@ -6261,8 +6260,7 @@ static void cmd_free(struct ctlr_info *h, struct CommandList *c)
int i;

i = c - h->cmd_pool;
- clear_bit(i & (BITS_PER_LONG - 1),
- h->cmd_pool_bits + (i / BITS_PER_LONG));
+ clear_bit(i, h->cmd_pool_bits);
}
}

--
2.34.1

2022-08-02 21:05:57

by Don Brace

Subject: Re: [PATCH 2/2] scsi: hpsa: Simplify {clear|set}_bit() parameters

From: Christophe JAILLET <[email protected]>
Sent: Wednesday, July 20, 2022 1:14 PM
To: Don Brace - C33706 <[email protected]>; James E.J. Bottomley <[email protected]>; Martin K. Petersen <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; Christophe JAILLET <[email protected]>; storagedev <[email protected]>; [email protected] <[email protected]>
Subject: [PATCH 2/2] scsi: hpsa: Simplify {clear|set}_bit() parameters
?
[Some people who received this message don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

{clear|set}_bit() can take an almost arbitrarily large bit number, so there
is no need to manually compute addresses. This is just redundant.

Signed-off-by: Christophe JAILLET <[email protected]>

Acked-by: Don Brace <[email protected]>
Tested-by: Don Brace <[email protected]>

We normally do not make changes to this driver anymore. But the change looks good.
Thanks for your patch. No cover letter to Ack both at the same time.

Don
---
?drivers/scsi/hpsa.c | 6 ++----
?1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 0612ca681200..f8e832b1bc46 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6233,8 +6233,7 @@ static struct CommandList *cmd_alloc(struct ctlr_info *h)
??????????????????????? offset = (i + 1) % HPSA_NRESERVED_CMDS;
??????????????????????? continue;
??????????????? }
-?????????????? set_bit(i & (BITS_PER_LONG - 1),
-?????????????????????? h->cmd_pool_bits + (i / BITS_PER_LONG));
+?????????????? set_bit(i, h->cmd_pool_bits);
??????????????? break; /* it's ours now. */
??????? }
??????? hpsa_cmd_partial_init(h, i, c);
@@ -6261,8 +6260,7 @@ static void cmd_free(struct ctlr_info *h, struct CommandList *c)
??????????????? int i;

??????????????? i = c - h->cmd_pool;
-?????????????? clear_bit(i & (BITS_PER_LONG - 1),
-???????????????????????? h->cmd_pool_bits + (i / BITS_PER_LONG));
+?????????????? clear_bit(i, h->cmd_pool_bits);
??????? }
?}

--
2.34.1