2023-03-17 05:50:24

by Jiapeng Chong

Subject: [PATCH] scsi: hpsa: Remove the unused variable transMethod

Variable transMethod is not effectively used, so delete it.

drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but not used.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4554
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/hpsa.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index fec7e17747f7..2f2b46a95102 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9475,8 +9475,6 @@ static void hpsa_free_performant_mode(struct ctlr_info *h)
static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)
{
u32 trans_support;
- unsigned long transMethod = CFGTBL_Trans_Performant |
- CFGTBL_Trans_use_short_tags;
int i, rc;

if (hpsa_simple_mode)
@@ -9488,14 +9486,10 @@ static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)

/* Check for I/O accelerator mode support */
if (trans_support & CFGTBL_Trans_io_accel1) {
- transMethod |= CFGTBL_Trans_io_accel1 |
- CFGTBL_Trans_enable_directed_msix;
rc = hpsa_alloc_ioaccel1_cmd_and_bft(h);
if (rc)
return rc;
} else if (trans_support & CFGTBL_Trans_io_accel2) {
- transMethod |= CFGTBL_Trans_io_accel2 |
- CFGTBL_Trans_enable_directed_msix;
rc = hpsa_alloc_ioaccel2_cmd_and_bft(h);
if (rc)
return rc;
--
2.20.1.7.g153144c

2023-03-17 15:18:19

by Don Brace

Subject: RE: [PATCH] scsi: hpsa: Remove the unused variable transMethod

-----Original Message-----
From: Jiapeng Chong [mailto:[email protected]]
Subject: [PATCH] scsi: hpsa: Remove the unused variable transMethod

Variable transMethod is not effectively used, so delete it.

drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but not used.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4554
Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: Don Brace <[email protected]>
Thanks for your patch.

---
drivers/scsi/hpsa.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index fec7e17747f7..2f2b46a95102 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9475,8 +9475,6 @@ static void hpsa_free_performant_mode(struct ctlr_info *h) static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h) {
u32 trans_support;
- unsigned long transMethod = CFGTBL_Trans_Performant |
- CFGTBL_Trans_use_short_tags;
int i, rc;

if (hpsa_simple_mode)
@@ -9488,14 +9486,10 @@ static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)

/* Check for I/O accelerator mode support */
if (trans_support & CFGTBL_Trans_io_accel1) {
- transMethod |= CFGTBL_Trans_io_accel1 |
- CFGTBL_Trans_enable_directed_msix;
rc = hpsa_alloc_ioaccel1_cmd_and_bft(h);
if (rc)
return rc;
} else if (trans_support & CFGTBL_Trans_io_accel2) {
- transMethod |= CFGTBL_Trans_io_accel2 |
- CFGTBL_Trans_enable_directed_msix;
rc = hpsa_alloc_ioaccel2_cmd_and_bft(h);
if (rc)
return rc;
--
2.20.1.7.g153144c

2023-03-24 21:02:04

by Martin K. Petersen

Subject: Re: [PATCH] scsi: hpsa: Remove the unused variable transMethod

Jiapeng,

> Variable transMethod is not effectively used, so delete it.
>
> drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but
> not used.

Applied to 6.4/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2023-04-03 02:17:11

by Martin K. Petersen

Subject: Re: [PATCH] scsi: hpsa: Remove the unused variable transMethod

On Fri, 17 Mar 2023 13:49:40 +0800, Jiapeng Chong wrote:

> Variable transMethod is not effectively used, so delete it.
>
> drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but not used.
>
>

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: hpsa: Remove the unused variable transMethod
https://git.kernel.org/mkp/scsi/c/d93523877e6f

--
Martin K. Petersen Oracle Linux Engineering