GMAC controller on HSDK boards supports 256 Hash Table size so we need to
add the multicast filter bins property. This allows for the Hash filter
to work properly using stmmac driver.
Signed-off-by: Jose Abreu <[email protected]>
Cc: Joao Pinto <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Vineet Gupta <[email protected]>
---
arch/arc/boot/dts/hsdk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
index 69bc1c9e8e50..b0f059377ab0 100644
--- a/arch/arc/boot/dts/hsdk.dts
+++ b/arch/arc/boot/dts/hsdk.dts
@@ -187,6 +187,7 @@
interrupt-names = "macirq";
phy-mode = "rgmii";
snps,pbl = <32>;
+ snps,multicast-filter-bins = <256>;
clocks = <&gmacclk>;
clock-names = "stmmaceth";
phy-handle = <&phy0>;
--
2.7.4
+CC Alexey, Eugeniy who maintain hsdk support !
On 5/2/19 8:12 AM, Jose Abreu wrote:
> GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> add the multicast filter bins property. This allows for the Hash filter
> to work properly using stmmac driver.
>
> Signed-off-by: Jose Abreu <[email protected]>
> Cc: Joao Pinto <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Cc: Vineet Gupta <[email protected]>
> ---
> arch/arc/boot/dts/hsdk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index 69bc1c9e8e50..b0f059377ab0 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -187,6 +187,7 @@
> interrupt-names = "macirq";
> phy-mode = "rgmii";
> snps,pbl = <32>;
> + snps,multicast-filter-bins = <256>;
> clocks = <&gmacclk>;
> clock-names = "stmmaceth";
> phy-handle = <&phy0>;
>
Hi,
I'll check this in the next few days.
On Thu, 2019-05-02 at 08:41 -0700, Vineet Gupta wrote:
> +CC Alexey, Eugeniy who maintain hsdk support !
>
> On 5/2/19 8:12 AM, Jose Abreu wrote:
> > GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> > add the multicast filter bins property. This allows for the Hash filter
> > to work properly using stmmac driver.
> >
> > Signed-off-by: Jose Abreu <[email protected]>
> > Cc: Joao Pinto <[email protected]>
> > Cc: Rob Herring <[email protected]>
> > Cc: Mark Rutland <[email protected]>
> > Cc: Vineet Gupta <[email protected]>
> > ---
> > arch/arc/boot/dts/hsdk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> > index 69bc1c9e8e50..b0f059377ab0 100644
> > --- a/arch/arc/boot/dts/hsdk.dts
> > +++ b/arch/arc/boot/dts/hsdk.dts
> > @@ -187,6 +187,7 @@
> > interrupt-names = "macirq";
> > phy-mode = "rgmii";
> > snps,pbl = <32>;
> > + snps,multicast-filter-bins = <256>;
> > clocks = <&gmacclk>;
> > clock-names = "stmmaceth";
> > phy-handle = <&phy0>;
> >
>
>
--
Eugeniy Paltsev
From: Eugeniy Paltsev <[email protected]>
Date: Mon, May 06, 2019 at 19:19:20
> Hi,
>
> I'll check this in the next few days.
>
I also noticed that FIFO size entry is missing. DWMAC1000 does not
support automatic FIFO size detection so this entry needs to be added.
Thanks,
Jose Miguel Abreu
Hi Jose,
> -----Original Message-----
> From: Jose Abreu <[email protected]>
> Sent: Wednesday, May 8, 2019 10:29 AM
> To: Eugeniy Paltsev <[email protected]>; [email protected]; [email protected];
> Vineet Gupta <[email protected]>; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected]; Alexey Brodkin
> <[email protected]>
> Subject: RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
>
> From: Eugeniy Paltsev <[email protected]>
> Date: Mon, May 06, 2019 at 19:19:20
>
> > Hi,
> >
> > I'll check this in the next few days.
> >
>
> I also noticed that FIFO size entry is missing. DWMAC1000 does not
> support automatic FIFO size detection so this entry needs to be added.
Could you please propose a patch?
-Alexey
From: Alexey Brodkin <[email protected]>
Date: Wed, May 08, 2019 at 11:46:36
> Could you please propose a patch?
I couldn't yet find the exact FIFO size of the HW (it's not described in
the documents I have). Do you have the values ?
Thanks,
Jose Miguel Abreu