2019-01-23 07:57:21

by Gustavo A. R. Silva

Subject: [PATCH net-next] bna: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index a36e38676640..cbc9175d74c5 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)

case IOCPF_E_INITFAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through */
+
case IOCPF_E_TIMEOUT:
bfa_nw_ioc_hw_sem_release(ioc);
if (event == IOCPF_E_TIMEOUT)
@@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)

case IOCPF_E_FAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through*/

case IOCPF_E_TIMEOUT:
bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
--
2.20.1

2019-01-23 08:05:13

by Sudarsana Reddy Kalluru

Subject: RE: [PATCH net-next] bna: Mark expected switch fall-throughs

-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: 23 January 2019 13:23
To: Rasesh Mody <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH net-next] bna: Mark expected switch fall-throughs

External Email

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index a36e38676640..cbc9175d74c5 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)

case IOCPF_E_INITFAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through */
+
case IOCPF_E_TIMEOUT:
bfa_nw_ioc_hw_sem_release(ioc);
if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)

case IOCPF_E_FAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through*/

case IOCPF_E_TIMEOUT:
bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
--
2.20.1

Acked-by: Sudarsana Kalluru <[email protected]>

2019-01-23 08:08:28

by Gustavo A. R. Silva

Subject: Re: [PATCH net-next] bna: Mark expected switch fall-throughs

On 1/23/19 2:03 AM, Sudarsana Reddy Kalluru wrote:
> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:[email protected]]
> Sent: 23 January 2019 13:23
> To: Rasesh Mody <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>
> Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
> Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
>
> External Email
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
> index a36e38676640..cbc9175d74c5 100644
> --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
> +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
> @@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
>
> case IOCPF_E_INITFAIL:
> del_timer(&ioc->iocpf_timer);
> - /*
> - * !!! fall through !!!
> - */
> + /* fall through */
> +
> case IOCPF_E_TIMEOUT:
> bfa_nw_ioc_hw_sem_release(ioc);
> if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
>
> case IOCPF_E_FAIL:
> del_timer(&ioc->iocpf_timer);
> - /*
> - * !!! fall through !!!
> - */
> + /* fall through*/
>
> case IOCPF_E_TIMEOUT:
> bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
> --
> 2.20.1
>
> Acked-by: Sudarsana Kalluru <[email protected]>
>

Thanks, Sudarsana.

--
Gustavo

2019-01-23 17:09:32

by David Miller

Subject: Re: [PATCH net-next] bna: Mark expected switch fall-throughs

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 23 Jan 2019 01:53:28 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied.

2019-01-23 17:11:06

by David Miller

Subject: Re: [PATCH net-next] bna: Mark expected switch fall-throughs

From: Sudarsana Reddy Kalluru <[email protected]>
Date: Wed, 23 Jan 2019 08:03:12 +0000

> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:[email protected]]
> Sent: 23 January 2019 13:23
> To: Rasesh Mody <[email protected]>; Sudarsana Kalluru <[email protected]>; [email protected]; David S. Miller <[email protected]>
> Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
> Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
>
> External Email
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied.