2024-03-14 11:29:39

by Esteban Blanc

Subject: Re: [PATCH v3 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO

On Fri Mar 8, 2024 at 11:34 AM CET, Bhargav Raviprakash wrote:
> From: Nirmala Devi Mal Nadar <[email protected]>
>
> Add support for TPS65224 pinctrl and GPIOs to TPS6594 driver as they have
> significant functional overlap.
> TPS65224 PMIC has 6 GPIOS which can be configured as GPIO or other
> dedicated device functions.
>
> Signed-off-by: Nirmala Devi Mal Nadar <[email protected]>
> Signed-off-by: Bhargav Raviprakash <[email protected]>
> Acked-by: Linus Walleij <[email protected]>

Hi,

What changed here compared to the previous version?

You might have missed my previous email[1] since I don't see any of changes
I suggested.

[1] https://lore.kernel.org/r/[email protected]/

Best regards,

--
Esteban "Skallwar" Blanc
BayLibre

2024-03-20 10:19:21

by Bhargav Raviprakash

Subject: Re: [PATCH v3 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO

Hello,

On Thu, 14 Mar 2024 12:29:23 +0100, Esteban Blanc wrote:
> On Fri Mar 8, 2024 at 11:34 AM CET, Bhargav Raviprakash wrote:
> > From: Nirmala Devi Mal Nadar <[email protected]>
> >
> > Add support for TPS65224 pinctrl and GPIOs to TPS6594 driver as they have
> > significant functional overlap.
> > TPS65224 PMIC has 6 GPIOS which can be configured as GPIO or other
> > dedicated device functions.
> >
> > Signed-off-by: Nirmala Devi Mal Nadar <[email protected]>
> > Signed-off-by: Bhargav Raviprakash <[email protected]>
> > Acked-by: Linus Walleij <[email protected]>
>
> Hi,
>
> What changed here compared to the previous version?
>
> You might have missed my previous email[1] since I don't see any of changes
> I suggested.
>
> [1] https://lore.kernel.org/r/[email protected]/
>
> Best regards,
>
> --
> Esteban "Skallwar" Blanc
> BayLibre

Thanks for the feedback!
It will be addressed in the next version.
We have regrouped wherever logically possible.

Regards,
Bhargav