2007-02-23 13:30:24

by Joerg Dorchain

[permalink] [raw]

Subject: [Patch] bug in gdth.c crashing machine

---

Hello Achim,

wrt to your mail to the lkml from 13 Oct 2006 Message-ID:
<[email protected]>,
I'd be pleased if you could integrate the derived patch into a bugfix
release of the driver asap.

This bug kept me busy for three days, endangering backup to tapes.

Patch is against vanilla 2.6.20.

Kind regards,

Joerg

Signed-off-by: Joerg Dorchain <[email protected]>

--- gdth.c.orig 2007-02-23 12:48:56.000000000 +0100
+++ gdth.c 2007-02-23 12:51:44.000000000 +0100
@@ -3092,6 +3092,7 @@
cmdp->u.raw64.direction =
gdth_direction_tab[scp->cmnd[0]]==DOU ? GDTH_DATA_OUT:GDTH_DATA_IN;
memcpy(cmdp->u.raw64.cmd,scp->cmnd,16);
+ cmdp->u.raw64.sg_ranz = 0;
} else {
cmdp->u.raw.reserved = 0;
cmdp->u.raw.mdisc_time = 0;
@@ -3108,6 +3109,7 @@
cmdp->u.raw.direction =
gdth_direction_tab[scp->cmnd[0]]==DOU ? GDTH_DATA_OUT:GDTH_DATA_IN;
memcpy(cmdp->u.raw.cmd,scp->cmnd,12);
+ cmdp->u.raw.sg_ranz = 0;
}

if (scp->use_sg) {

---

Attachments:

(No filename) (1.11 kB)
signature.asc (189.00 B)
Digital signature Download all attachments

2007-02-23 14:14:06

by Leubner, Achim

[permalink] [raw]

Subject: RE: [Patch] bug in gdth.c crashing machine

---

Hi Joerg,

You are right, this patch should be added to a bugfix release as soon as
possible.

Thanks,
Achim

=======================
Achim Leubner
Software Engineer / RAID drivers
ICP vortex GmbH / Adaptec Inc.
Phone: +49-351-8718291


-----Original Message-----
From: Joerg Dorchain [mailto:[email protected]]
Sent: Freitag, 23. Februar 2007 14:30
To: Leubner, Achim
Cc: [email protected]
Subject: [Patch] bug in gdth.c crashing machine

Hello Achim,

wrt to your mail to the lkml from 13 Oct 2006 Message-ID:
<[email protected]>,
I'd be pleased if you could integrate the derived patch into a bugfix
release of the driver asap.

This bug kept me busy for three days, endangering backup to tapes.

Patch is against vanilla 2.6.20.

Kind regards,

Joerg

Signed-off-by: Joerg Dorchain <[email protected]>

--- gdth.c.orig 2007-02-23 12:48:56.000000000 +0100
+++ gdth.c 2007-02-23 12:51:44.000000000 +0100
@@ -3092,6 +3092,7 @@
cmdp->u.raw64.direction =
gdth_direction_tab[scp->cmnd[0]]==DOU ?
GDTH_DATA_OUT:GDTH_DATA_IN;
memcpy(cmdp->u.raw64.cmd,scp->cmnd,16);
+ cmdp->u.raw64.sg_ranz = 0;
} else {
cmdp->u.raw.reserved = 0;
cmdp->u.raw.mdisc_time = 0;
@@ -3108,6 +3109,7 @@
cmdp->u.raw.direction =
gdth_direction_tab[scp->cmnd[0]]==DOU ?
GDTH_DATA_OUT:GDTH_DATA_IN;
memcpy(cmdp->u.raw.cmd,scp->cmnd,12);
+ cmdp->u.raw.sg_ranz = 0;
}

if (scp->use_sg) {