2015-05-06 17:28:35

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 1/5] selftests: Add futex functional tests

On 03/27/2015 04:17 PM, Darren Hart wrote:
> The futextest testsuite [1] provides functional, stress, and
> performance tests for the various futex op codes. Those tests will be of
> more use to futex developers if they are included with the kernel
> source.
>
> Copy the core infrastructure and the functional tests into selftests.
> Remove reference to the performance and stress tests from the
> contributed sources.
>
> Remove the Free Software Foundation address paragraph from all
> contributed files to avoid checkpatch complaints.
>
> A future effort will explore moving the performance and stress tests
> into the kernel.
>
> 1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git
>
> Cc: Shuah Khan <[email protected]>
> Cc: [email protected]
> Cc: Ingo Molnar <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Davidlohr Bueso <[email protected]>
> Cc: KOSAKI Motohiro <[email protected]>
> Signed-off-by: Darren Hart <[email protected]>

Sorry it took so long. I am just about to apply these to linux-kselftest
next and ran into checkpatch errors on this patch.

Could you clean them and resend this patch. Other patches in this series
are good.

thanks,
-- Shuah


--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978


2015-05-06 18:04:31

by Darren Hart

[permalink] [raw]
Subject: Re: [PATCH 1/5] selftests: Add futex functional tests

On 5/6/15, 10:28 AM, "Shuah Khan" <[email protected]> wrote:

>On 03/27/2015 04:17 PM, Darren Hart wrote:
>> The futextest testsuite [1] provides functional, stress, and
>> performance tests for the various futex op codes. Those tests will be of
>> more use to futex developers if they are included with the kernel
>> source.
>>
>> Copy the core infrastructure and the functional tests into selftests.
>> Remove reference to the performance and stress tests from the
>> contributed sources.
>>
>> Remove the Free Software Foundation address paragraph from all
>> contributed files to avoid checkpatch complaints.
>>
>> A future effort will explore moving the performance and stress tests
>> into the kernel.
>>
>> 1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git
>>
>> Cc: Shuah Khan <[email protected]>
>> Cc: [email protected]
>> Cc: Ingo Molnar <[email protected]>
>> Cc: Peter Zijlstra <[email protected]>
>> Cc: Thomas Gleixner <[email protected]>
>> Cc: Davidlohr Bueso <[email protected]>
>> Cc: KOSAKI Motohiro <[email protected]>
>> Signed-off-by: Darren Hart <[email protected]>
>
>Sorry it took so long. I am just about to apply these to linux-kselftest
>next and ran into checkpatch errors on this patch.

*GASP* How humiliating.... Of course. Something by late tonight.

--
Darren Hart
Intel Open Source Technology Center