2015-07-22 22:08:32

by Spencer Baugh

Subject: [PATCH] qla2xxx: remove unused rval

From: Joern Engel <[email protected]>

We don't touch the return value of qla2x00_loop_resync in
qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.

Signed-off-by: Joern Engel <[email protected]>
Signed-off-by: Spencer Baugh <[email protected]>
---
drivers/scsi/qla2xxx/qla_os.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index a28815b..b9ee115 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4793,7 +4793,6 @@ qla2x00_disable_board_on_pci_error(struct work_struct *work)
static int
qla2x00_do_dpc(void *data)
{
- int rval;
scsi_qla_host_t *base_vha;
struct qla_hw_data *ha;

@@ -5025,7 +5024,7 @@ loop_resync_check:
if (!(test_and_set_bit(LOOP_RESYNC_ACTIVE,
&base_vha->dpc_flags))) {

- rval = qla2x00_loop_resync(base_vha);
+ qla2x00_loop_resync(base_vha);

clear_bit(LOOP_RESYNC_ACTIVE,
&base_vha->dpc_flags);
--
2.5.0.rc3

2015-07-22 22:17:40

by Himanshu Madhani

Subject: Re: [PATCH] qla2xxx: remove unused rval

On 7/22/15, 3:08 PM, "Spencer Baugh" <[email protected]> wrote:

>From: Joern Engel <[email protected]>
>
>We don't touch the return value of qla2x00_loop_resync in
>qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
>
>Signed-off-by: Joern Engel <[email protected]>
>Signed-off-by: Spencer Baugh <[email protected]>
>---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
>index a28815b..b9ee115 100644
>--- a/drivers/scsi/qla2xxx/qla_os.c
>+++ b/drivers/scsi/qla2xxx/qla_os.c
>@@ -4793,7 +4793,6 @@ qla2x00_disable_board_on_pci_error(struct
>work_struct *work)
> static int
> qla2x00_do_dpc(void *data)
> {
>- int rval;
> scsi_qla_host_t *base_vha;
> struct qla_hw_data *ha;
>
>@@ -5025,7 +5024,7 @@ loop_resync_check:
> if (!(test_and_set_bit(LOOP_RESYNC_ACTIVE,
> &base_vha->dpc_flags))) {
>
>- rval = qla2x00_loop_resync(base_vha);
>+ qla2x00_loop_resync(base_vha);
>
> clear_bit(LOOP_RESYNC_ACTIVE,
> &base_vha->dpc_flags);
>--
>2.5.0.rc3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/

Acked-by: Himanshu Madhani <[email protected]>


>