2024-05-30 01:02:37

by Jeff Johnson

Subject: [PATCH] KEYS: trusted: add MODULE_DESCRIPTION()

Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o

Signed-off-by: Jeff Johnson <[email protected]>
---
security/keys/trusted-keys/trusted_core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c
index 5113aeae5628..f4ab16d59663 100644
--- a/security/keys/trusted-keys/trusted_core.c
+++ b/security/keys/trusted-keys/trusted_core.c
@@ -395,4 +395,5 @@ static void __exit cleanup_trusted(void)
late_initcall(init_trusted);
module_exit(cleanup_trusted);

+MODULE_DESCRIPTION("Trusted Key support");
MODULE_LICENSE("GPL");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-md-trusted-6e6fd26299ad

2024-05-30 05:39:44

by Jarkko Sakkinen

Subject: Re: [PATCH] KEYS: trusted: add MODULE_DESCRIPTION()

On Thu May 30, 2024 at 4:02 AM EEST, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o

Maybe instead:

"""
KEYS: trusted: Add the missing MODULE_DESCRIPTION()

kbuild reports:

WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o

Add the missing MODULE_DESCRIPTION() macro invocation.
"""

BR, Jarkko

2024-05-30 14:09:36

by Jeff Johnson

Subject: Re: [PATCH] KEYS: trusted: add MODULE_DESCRIPTION()

On 5/29/2024 10:39 PM, Jarkko Sakkinen wrote:
> On Thu May 30, 2024 at 4:02 AM EEST, Jeff Johnson wrote:
>> Fix the 'make W=1' warning:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o
>
> Maybe instead:
>
> """
> KEYS: trusted: Add the missing MODULE_DESCRIPTION()
>
> kbuild reports:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o
>
> Add the missing MODULE_DESCRIPTION() macro invocation.

Can do, v2 coming...