2024-05-24 19:55:36

by Paul E. McKenney

[permalink] [raw]
Subject: [BUG] Build failure and alleged fix for next-20240523

Hello!

I get the following allmodconfig build error on x86 in next-20240523:

Traceback (most recent call last):
??File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
????main()
??File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
????parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'

The following patch allows the build to complete successfully:

https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#25842751

As to whether this is a proper fix, I must defer to the DRM folks on CC.

Thanx, Paul


2024-05-24 19:58:29

by Abhinav Kumar

[permalink] [raw]
Subject: Re: [BUG] Build failure and alleged fix for next-20240523

Hello

On 5/24/2024 12:55 PM, Paul E. McKenney wrote:
> Hello!
>
> I get the following allmodconfig build error on x86 in next-20240523:
>
> Traceback (most recent call last):
>   File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
>     main()
>   File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
>     parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'
>
> The following patch allows the build to complete successfully:
>
> https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#25842751
>
> As to whether this is a proper fix, I must defer to the DRM folks on CC.
>
> Thanx, Paul
>

Thanks for the report.

I have raised a merge request for
https://patchwork.freedesktop.org/patch/593057/ to make it available for
the next fixes release for msm.

Abhinav

2024-05-24 21:13:20

by Jon Hunter

[permalink] [raw]
Subject: Re: [BUG] Build failure and alleged fix for next-20240523


On 24/05/2024 20:57, Abhinav Kumar wrote:
> Hello
>
> On 5/24/2024 12:55 PM, Paul E. McKenney wrote:
>> Hello!
>>
>> I get the following allmodconfig build error on x86 in next-20240523:
>>
>> Traceback (most recent call last):
>>    File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in
>> <module>
>>      main()
>>    File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
>>      parser.add_argument('--validate',
>> action=argparse.BooleanOptionalAction)
>> AttributeError: module 'argparse' has no attribute
>> 'BooleanOptionalAction'
>>
>> The following patch allows the build to complete successfully:
>>
>> https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#25842751
>>
>> As to whether this is a proper fix, I must defer to the DRM folks on CC.
>>
>>                             Thanx, Paul
>>
>
> Thanks for the report.
>
> I have raised a merge request for
> https://patchwork.freedesktop.org/patch/593057/ to make it available for
> the next fixes release for msm.


This is also now in the mainline and so would be great to get this into
both -next and mainline.

Jon

--
nvpublic

2024-05-30 16:56:36

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [BUG] Build failure and alleged fix for next-20240523

On Fri, May 24, 2024 at 12:57:58PM -0700, Abhinav Kumar wrote:
> Hello
>
> On 5/24/2024 12:55 PM, Paul E. McKenney wrote:
> > Hello!
> >
> > I get the following allmodconfig build error on x86 in next-20240523:
> >
> > Traceback (most recent call last):
> > ??File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
> > ????main()
> > ??File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
> > ????parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> > AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'
> >
> > The following patch allows the build to complete successfully:
> >
> > https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#25842751
> >
> > As to whether this is a proper fix, I must defer to the DRM folks on CC.
>
> Thanks for the report.
>
> I have raised a merge request for
> https://patchwork.freedesktop.org/patch/593057/ to make it available for the
> next fixes release for msm.

Thank you!

This still is not in -next, so I am putting it into -rcu just to silence
the diagnostic. Or should I push this to mainline via -rcu?

Thanx, Paul

2024-05-30 18:28:33

by Thierry Reding

[permalink] [raw]
Subject: Re: [BUG] Build failure and alleged fix for next-20240523

On Thu May 30, 2024 at 6:55 PM CEST, Paul E. McKenney wrote:
> On Fri, May 24, 2024 at 12:57:58PM -0700, Abhinav Kumar wrote:
> > Hello
> >
> > On 5/24/2024 12:55 PM, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > I get the following allmodconfig build error on x86 in next-20240523:
> > >
> > > Traceback (most recent call last):
> > >   File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
> > >     main()
> > >   File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
> > >     parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> > > AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'
> > >
> > > The following patch allows the build to complete successfully:
> > >
> > > https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#25842751
> > >
> > > As to whether this is a proper fix, I must defer to the DRM folks on CC.
> >
> > Thanks for the report.
> >
> > I have raised a merge request for
> > https://patchwork.freedesktop.org/patch/593057/ to make it available for the
> > next fixes release for msm.
>
> Thank you!
>
> This still is not in -next, so I am putting it into -rcu just to silence
> the diagnostic. Or should I push this to mainline via -rcu?

I pushed this to drm-misc-fixes earlier today, so should show up in
linux-next soon and hopefully in v6.10-rc2.

Thierry


Attachments:
signature.asc (849.00 B)

2024-05-30 20:41:06

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [BUG] Build failure and alleged fix for next-20240523

On Thu, May 30, 2024 at 08:28:17PM +0200, Thierry Reding wrote:
> On Thu May 30, 2024 at 6:55 PM CEST, Paul E. McKenney wrote:
> > On Fri, May 24, 2024 at 12:57:58PM -0700, Abhinav Kumar wrote:
> > > Hello
> > >
> > > On 5/24/2024 12:55 PM, Paul E. McKenney wrote:
> > > > Hello!
> > > >
> > > > I get the following allmodconfig build error on x86 in next-20240523:
> > > >
> > > > Traceback (most recent call last):
> > > > ??File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in <module>
> > > > ????main()
> > > > ??File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
> > > > ????parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
> > > > AttributeError: module 'argparse' has no attribute 'BooleanOptionalAction'
> > > >
> > > > The following patch allows the build to complete successfully:
> > > >
> > > > https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/#25842751
> > > >
> > > > As to whether this is a proper fix, I must defer to the DRM folks on CC.
> > >
> > > Thanks for the report.
> > >
> > > I have raised a merge request for
> > > https://patchwork.freedesktop.org/patch/593057/ to make it available for the
> > > next fixes release for msm.
> >
> > Thank you!
> >
> > This still is not in -next, so I am putting it into -rcu just to silence
> > the diagnostic. Or should I push this to mainline via -rcu?
>
> I pushed this to drm-misc-fixes earlier today, so should show up in
> linux-next soon and hopefully in v6.10-rc2.

Thank you, Thierry!

Thanx, Paul