2016-04-14 09:40:21

by Dan Carpenter

Subject: [patch] bnx2i: silence uninitialized variable warnings

Presumably it isn't possible to have empty lists here, but my static
checker doesn't know that and complains that "ep" can be used
uninitialized.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
index 7289437..133901f 100644
--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
@@ -675,7 +675,7 @@ bnx2i_find_ep_in_ofld_list(struct bnx2i_hba *hba, u32 iscsi_cid)
{
struct list_head *list;
struct list_head *tmp;
- struct bnx2i_endpoint *ep;
+ struct bnx2i_endpoint *ep = NULL;

read_lock_bh(&hba->ep_rdwr_lock);
list_for_each_safe(list, tmp, &hba->ep_ofld_list) {
@@ -703,7 +703,7 @@ bnx2i_find_ep_in_destroy_list(struct bnx2i_hba *hba, u32 iscsi_cid)
{
struct list_head *list;
struct list_head *tmp;
- struct bnx2i_endpoint *ep;
+ struct bnx2i_endpoint *ep = NULL;

read_lock_bh(&hba->ep_rdwr_lock);
list_for_each_safe(list, tmp, &hba->ep_destroy_list) {

2016-04-18 05:51:53

by Nilesh Javali

Subject: Re: [patch] bnx2i: silence uninitialized variable warnings

On 14/04/16 3:10 PM, "Dan Carpenter" <[email protected]> wrote:

>Presumably it isn't possible to have empty lists here, but my static
>checker doesn't know that and complains that "ep" can be used
>uninitialized.
>
>Signed-off-by: Dan Carpenter <[email protected]>
>
>diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
>b/drivers/scsi/bnx2i/bnx2i_iscsi.c
>index 7289437..133901f 100644
>--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
>+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
>@@ -675,7 +675,7 @@ bnx2i_find_ep_in_ofld_list(struct bnx2i_hba *hba, u32
>iscsi_cid)
> {
> struct list_head *list;
> struct list_head *tmp;
>- struct bnx2i_endpoint *ep;
>+ struct bnx2i_endpoint *ep = NULL;
>
> read_lock_bh(&hba->ep_rdwr_lock);
> list_for_each_safe(list, tmp, &hba->ep_ofld_list) {
>@@ -703,7 +703,7 @@ bnx2i_find_ep_in_destroy_list(struct bnx2i_hba *hba,
>u32 iscsi_cid)
> {
> struct list_head *list;
> struct list_head *tmp;
>- struct bnx2i_endpoint *ep;
>+ struct bnx2i_endpoint *ep = NULL;
>
> read_lock_bh(&hba->ep_rdwr_lock);
> list_for_each_safe(list, tmp, &hba->ep_destroy_list) {

Acked-by: Nilesh Javali <[email protected]>

2016-04-26 02:03:35

by Martin K. Petersen

Subject: Re: [patch] bnx2i: silence uninitialized variable warnings

>>>>> "Dan" == Dan Carpenter <[email protected]> writes:

Dan> Presumably it isn't possible to have empty lists here, but my
Dan> static checker doesn't know that and complains that "ep" can be
Dan> used uninitialized.

Applied to 4.7/scsi-queue.

--
Martin K. Petersen Oracle Linux Engineering