2008-10-07 20:35:46

by Joseph Cihula

[permalink] [raw]
Subject: [RFC][PATCH 1/3] TXT: ACPI AddressRangeUnusuable support

See attached commit message (w/ patch), copied below:

Add support for the E820_UNUSABLE memory type, which is defined in
Revision 3.0b (Oct. 10, 2006) of the ACPI Specification on p. 394
Table
14-1:

AddressRangeUnusuable This range of address contains memory in which
errors have been detected. This range must not be used by the OSPM.

Signed-off-by: Joseph Cihula <[email protected]>
Signed-off-by: Shane Wang <[email protected]>
Signed-off-by: Gang Wei <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Andi Kleen <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---

arch/x86/kernel/e820.c | 4 ++++
include/asm-x86/e820.h | 1 +
2 files changed, 5 insertions(+)

diff -puN
arch/x86/kernel/e820.c~acpi-add-support-for-addressrangeunusuable-acpi-m
emory-type arch/x86/kernel/e820.c
---
a/arch/x86/kernel/e820.c~acpi-add-support-for-addressrangeunusuable-acpi
-memory-type
+++ a/arch/x86/kernel/e820.c
@@ -148,6 +148,9 @@ void __init e820_print_map(char *who)
case E820_NVS:
printk(KERN_CONT "(ACPI NVS)\n");
break;
+ case E820_UNUSABLE:
+ printk("(unusable)\n");
+ break;
default:
printk(KERN_CONT "type %u\n", e820.map[i].type);
break;
@@ -1260,6 +1263,7 @@ static inline const char *e820_type_to_s
case E820_RAM: return "System RAM";
case E820_ACPI: return "ACPI Tables";
case E820_NVS: return "ACPI Non-volatile Storage";
+ case E820_UNUSABLE: return "Unusable memory";
default: return "reserved";
}
}
diff -puN
include/asm-x86/e820.h~acpi-add-support-for-addressrangeunusuable-acpi-m
emory-type include/asm-x86/e820.h
---
a/include/asm-x86/e820.h~acpi-add-support-for-addressrangeunusuable-acpi
-memory-type
+++ a/include/asm-x86/e820.h
@@ -43,6 +43,7 @@
#define E820_RESERVED 2
#define E820_ACPI 3
#define E820_NVS 4
+#define E820_UNUSABLE 5

/* reserved RAM used by kernel itself */
#define E820_RESERVED_KERN 128


Attachments:
(No filename) (4.51 kB)

2008-10-08 00:54:38

by Andi Kleen

[permalink] [raw]
Subject: Re: [RFC][PATCH 1/3] TXT: ACPI AddressRangeUnusuable support

"Cihula, Joseph" <[email protected]> writes:
> +#define E820_UNUSABLE 5
>
> /* reserved RAM used by kernel itself */
> #define E820_RESERVED_KERN 128
>
> From: <[email protected]>

Something got corrupted? Your patch contains a mailbox with another
version of the patch.

> Subject: - acpi-add-support-for-addressrangeunusuable-acpi-memory-type.patch removed from -mm tree
> To: "Cihula, Joseph" <[email protected]>,
> <[email protected]>,
> "Wei, Gang" <[email protected]>,
> <[email protected]>,
> "Wang, Shane" <[email protected]>,
> <[email protected]>,
> <[email protected]>
> Date: Tue, 26 Aug 2008 11:44:49 -0700
>
>
> The patch titled
> acpi: add support for AddressRangeUnusuable ACPI memory type
> has been removed from the -mm tree. Its filename was
> acpi-add-support-for-addressrangeunusuable-acpi-memory-type.patch

-Andi
--
[email protected]

2008-10-08 04:32:32

by Joseph Cihula

[permalink] [raw]
Subject: RE: [RFC][PATCH 1/3] TXT: ACPI AddressRangeUnusuable support

> From: Andi Kleen [mailto:[email protected]]
> Sent: Tuesday, October 07, 2008 5:54 PM
>
> "Cihula, Joseph" <[email protected]> writes:
> > +#define E820_UNUSABLE 5
> >
> > /* reserved RAM used by kernel itself */
> > #define E820_RESERVED_KERN 128
> >
> > From: <[email protected]>
>
> Something got corrupted? Your patch contains a mailbox with another
> version of the patch.

It appears Outlook/Exchange munged more than just tabs and wrapping. My
most recent patch should be correct (at least the copy I received looks
fine).

>
> > Subject: - acpi-add-support-for-addressrangeunusuable-acpi-memory-
> type.patch removed from -mm tree
> > To: "Cihula, Joseph" <[email protected]>,
> > <[email protected]>,
> > "Wei, Gang" <[email protected]>,
> > <[email protected]>,
> > "Wang, Shane" <[email protected]>,
> > <[email protected]>,
> > <[email protected]>
> > Date: Tue, 26 Aug 2008 11:44:49 -0700
> >
> >
> > The patch titled
> > acpi: add support for AddressRangeUnusuable ACPI memory type
> > has been removed from the -mm tree. Its filename was
> > acpi-add-support-for-addressrangeunusuable-acpi-memory-
> type.patch
>
> -Andi
> --
> [email protected]