2020-03-03 06:08:18

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the thermal tree

Hi all,

After merging the thermal tree, today's linux-next build (powerpc
allyesconfig) failed like this:

ld: drivers/thermal/imx_sc_thermal.o: in function `.imx_sc_thermal_get_temp':
imx_sc_thermal.c:(.text.imx_sc_thermal_get_temp+0x68): undefined reference to `.imx_scu_call_rpc'
ld: drivers/thermal/imx_sc_thermal.o: in function `.imx_sc_thermal_probe':
imx_sc_thermal.c:(.text.imx_sc_thermal_probe+0x30): undefined reference to `.imx_scu_get_handle'

Caused by commit

ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support")

I have added the following patch for today.

From: Stephen Rothwell <[email protected]>
Date: Tue, 3 Mar 2020 16:52:49 +1100
Subject: [PATCH] thermal: imx_sc: remove COMPILE_TEST from IMX_SC_THERMAL

Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 478eda79520d..f3f70503df04 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -254,7 +254,7 @@ config IMX_THERMAL

config IMX_SC_THERMAL
tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller"
- depends on IMX_SCU || COMPILE_TEST
+ depends on IMX_SCU
depends on OF
help
Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-03-03 07:57:33

by Anson Huang

[permalink] [raw]
Subject: RE: linux-next: build failure after merge of the thermal tree

Hi, Daniel

> Subject: Re: linux-next: build failure after merge of the thermal tree
>
>
> Hi Anson,
>
> could be please fix those two errors (this one and the
> thermal_zone_of_get_sensor_id)


Sure, I will fix them and send out patch for review.

Thanks,
Anson

>
> Thanks
>
> -- Daniel
>
> On 03/03/2020 07:07, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the thermal tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > ld: drivers/thermal/imx_sc_thermal.o: in function
> `.imx_sc_thermal_get_temp':
> > imx_sc_thermal.c:(.text.imx_sc_thermal_get_temp+0x68): undefined
> reference to `.imx_scu_call_rpc'
> > ld: drivers/thermal/imx_sc_thermal.o: in function `.imx_sc_thermal_probe':
> > imx_sc_thermal.c:(.text.imx_sc_thermal_probe+0x30): undefined
> reference to `.imx_scu_get_handle'
> >
> > Caused by commit
> >
> > ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal
> > support")
> >
> > I have added the following patch for today.
> >
> > From: Stephen Rothwell <[email protected]>
> > Date: Tue, 3 Mar 2020 16:52:49 +1100
> > Subject: [PATCH] thermal: imx_sc: remove COMPILE_TEST from
> > IMX_SC_THERMAL
> >
> > Signed-off-by: Stephen Rothwell <[email protected]>
> > ---
> > drivers/thermal/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index
> > 478eda79520d..f3f70503df04 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -254,7 +254,7 @@ config IMX_THERMAL
> >
> > config IMX_SC_THERMAL
> > tristate "Temperature sensor driver for NXP i.MX SoCs with System
> Controller"
> > - depends on IMX_SCU || COMPILE_TEST
> > + depends on IMX_SCU
> > depends on OF
> > help
> > Support for Temperature Monitor (TEMPMON) found on NXP i.MX
> SoCs
> > with
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-
> blog/> Blog
>

2020-03-03 07:57:52

by Daniel Lezcano

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the thermal tree


Hi Anson,

could be please fix those two errors (this one and the
thermal_zone_of_get_sensor_id)

Thanks

-- Daniel

On 03/03/2020 07:07, Stephen Rothwell wrote:
> Hi all,
>
> After merging the thermal tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> ld: drivers/thermal/imx_sc_thermal.o: in function `.imx_sc_thermal_get_temp':
> imx_sc_thermal.c:(.text.imx_sc_thermal_get_temp+0x68): undefined reference to `.imx_scu_call_rpc'
> ld: drivers/thermal/imx_sc_thermal.o: in function `.imx_sc_thermal_probe':
> imx_sc_thermal.c:(.text.imx_sc_thermal_probe+0x30): undefined reference to `.imx_scu_get_handle'
>
> Caused by commit
>
> ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support")
>
> I have added the following patch for today.
>
> From: Stephen Rothwell <[email protected]>
> Date: Tue, 3 Mar 2020 16:52:49 +1100
> Subject: [PATCH] thermal: imx_sc: remove COMPILE_TEST from IMX_SC_THERMAL
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/thermal/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 478eda79520d..f3f70503df04 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -254,7 +254,7 @@ config IMX_THERMAL
>
> config IMX_SC_THERMAL
> tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller"
> - depends on IMX_SCU || COMPILE_TEST
> + depends on IMX_SCU
> depends on OF
> help
> Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog



Attachments:
signature.asc (235.00 B)
OpenPGP digital signature