2019-05-20 22:41:49

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the imx-mxs tree

Hi Shawn,

After merging the imx-mxs tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/clk/imx/clk.c: In function 'imx_mmdc_mask_handshake':
drivers/clk/imx/clk.c:20:8: error: implicit declaration of function 'readl_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-declaration]
reg = readl_relaxed(ccm_base + CCM_CCDR);
^~~~~~~~~~~~~
xchg_relaxed
drivers/clk/imx/clk.c:22:2: error: implicit declaration of function 'writel_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-declaration]
writel_relaxed(reg, ccm_base + CCM_CCDR);
^~~~~~~~~~~~~~
xchg_relaxed

Caused by commit

0dc6b492b6e0 ("clk: imx: Add common API for masking MMDC handshake")

I have used the imx-mxs tree from next-20190520 for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-05-21 02:18:12

by Anson Huang

[permalink] [raw]
Subject: RE: linux-next: build failure after merge of the imx-mxs tree

Hi, Stephen/Shawn
I realized this issue last week when I updated my Linux-next tree (NOT sure why I did NOT meet such issue when I did the patch), so I resent the patch series of adding head file "io.h" to fix this issue, please apply below V2 patch series instead, sorry for the inconvenience.

https://patchwork.kernel.org/patch/10944681/

thanks,
Anson.

> -----Original Message-----
> From: Stephen Rothwell [mailto:[email protected]]
> Sent: Tuesday, May 21, 2019 6:38 AM
> To: Shawn Guo <[email protected]>
> Cc: Linux Next Mailing List <[email protected]>; Linux Kernel Mailing
> List <[email protected]>; Anson Huang <[email protected]>;
> Aisheng Dong <[email protected]>
> Subject: linux-next: build failure after merge of the imx-mxs tree
>
> Hi Shawn,
>
> After merging the imx-mxs tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/clk/imx/clk.c: In function 'imx_mmdc_mask_handshake':
> drivers/clk/imx/clk.c:20:8: error: implicit declaration of function
> 'readl_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-
> declaration]
> reg = readl_relaxed(ccm_base + CCM_CCDR);
> ^~~~~~~~~~~~~
> xchg_relaxed
> drivers/clk/imx/clk.c:22:2: error: implicit declaration of function
> 'writel_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-
> declaration]
> writel_relaxed(reg, ccm_base + CCM_CCDR);
> ^~~~~~~~~~~~~~
> xchg_relaxed
>
> Caused by commit
>
> 0dc6b492b6e0 ("clk: imx: Add common API for masking MMDC handshake")
>
> I have used the imx-mxs tree from next-20190520 for today.
>
> --
> Cheers,
> Stephen Rothwell

2019-05-21 04:46:38

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the imx-mxs tree

On Tue, May 21, 2019 at 02:16:47AM +0000, Anson Huang wrote:
> Hi, Stephen/Shawn
> I realized this issue last week when I updated my Linux-next tree (NOT sure why I did NOT meet such issue when I did the patch), so I resent the patch series of adding head file "io.h" to fix this issue, please apply below V2 patch series instead, sorry for the inconvenience.
>
> https://patchwork.kernel.org/patch/10944681/

Okay, fixed. Sorry for the breakage, Stephen.

Shawn

> > -----Original Message-----
> > From: Stephen Rothwell [mailto:[email protected]]
> > Sent: Tuesday, May 21, 2019 6:38 AM
> > To: Shawn Guo <[email protected]>
> > Cc: Linux Next Mailing List <[email protected]>; Linux Kernel Mailing
> > List <[email protected]>; Anson Huang <[email protected]>;
> > Aisheng Dong <[email protected]>
> > Subject: linux-next: build failure after merge of the imx-mxs tree
> >
> > Hi Shawn,
> >
> > After merging the imx-mxs tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/clk/imx/clk.c: In function 'imx_mmdc_mask_handshake':
> > drivers/clk/imx/clk.c:20:8: error: implicit declaration of function
> > 'readl_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-
> > declaration]
> > reg = readl_relaxed(ccm_base + CCM_CCDR);
> > ^~~~~~~~~~~~~
> > xchg_relaxed
> > drivers/clk/imx/clk.c:22:2: error: implicit declaration of function
> > 'writel_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-
> > declaration]
> > writel_relaxed(reg, ccm_base + CCM_CCDR);
> > ^~~~~~~~~~~~~~
> > xchg_relaxed
> >
> > Caused by commit
> >
> > 0dc6b492b6e0 ("clk: imx: Add common API for masking MMDC handshake")
> >
> > I have used the imx-mxs tree from next-20190520 for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell