2019-07-10 06:43:18

by Anson Huang

Subject: [PATCH V5 3/5] arm64: dts: imx8mm: Add system counter node

From: Anson Huang <[email protected]>

Add i.MX8MM system counter node to enable timer-imx-sysctr
broadcast timer driver.

Signed-off-by: Anson Huang <[email protected]>
---
Changes since V4:
- update the clock info using fixed clock node;
- correct the reg range;
- update the interrupt number as the system counter driver ONLY uses 1 irq now.
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index b5637f8..8cf7f34 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -560,6 +560,14 @@
#pwm-cells = <2>;
status = "disabled";
};
+
+ system_counter: timer@306a0000 {
+ compatible = "nxp,sysctr-timer";
+ reg = <0x306a0000 0x20000>;
+ interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&osc_24m>;
+ clock-names = "per";
+ };
};

aips3: bus@30800000 {
--
2.7.4

2019-07-22 04:04:31

by Shawn Guo

Subject: Re: [PATCH V5 3/5] arm64: dts: imx8mm: Add system counter node

On Wed, Jul 10, 2019 at 02:30:54PM +0800, [email protected] wrote:
> From: Anson Huang <[email protected]>
>
> Add i.MX8MM system counter node to enable timer-imx-sysctr
> broadcast timer driver.
>
> Signed-off-by: Anson Huang <[email protected]>

Do I need to wait for patch #1 landing before I apply #3 ~ #5, or can
they be applied independently (no breaking on anything)?

Shawn

> ---
> Changes since V4:
> - update the clock info using fixed clock node;
> - correct the reg range;
> - update the interrupt number as the system counter driver ONLY uses 1 irq now.
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index b5637f8..8cf7f34 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -560,6 +560,14 @@
> #pwm-cells = <2>;
> status = "disabled";
> };
> +
> + system_counter: timer@306a0000 {
> + compatible = "nxp,sysctr-timer";
> + reg = <0x306a0000 0x20000>;
> + interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc_24m>;
> + clock-names = "per";
> + };
> };
>
> aips3: bus@30800000 {
> --
> 2.7.4
>

2019-07-23 12:13:23

by Anson Huang

Subject: RE: [PATCH V5 3/5] arm64: dts: imx8mm: Add system counter node

Hi, Shawn

> On Wed, Jul 10, 2019 at 02:30:54PM +0800, [email protected] wrote:
> > From: Anson Huang <[email protected]>
> >
> > Add i.MX8MM system counter node to enable timer-imx-sysctr broadcast
> > timer driver.
> >
> > Signed-off-by: Anson Huang <[email protected]>
>
> Do I need to wait for patch #1 landing before I apply #3 ~ #5, or can they be
> applied independently (no breaking on anything)?

Without #1, system can bootup, but the system counter's freq will be incorrect,
although it does NOT impact normal function. So I think it is better to wait for
#1 landing. @[email protected], can you help review the #1 patch, since
I use a different way to fix the clock issue which is more simple.

Anson