2019-02-08 10:07:08

by Alexandre Belloni

[permalink] [raw]
Subject: [PATCH] rtc: imx-sc: depend on HAVE_ARM_SMCCC

Fix the following build issue:

drivers/rtc/rtc-imx-sc.o: In function `imx_sc_rtc_set_time':
>> rtc-imx-sc.c:(.text+0x212): undefined reference to `__arm_smccc_smc'

Fixes: 13a929f38ad7 ("rtc: imx-sc: add rtc set time support")
Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index faa9ae1a3062..8f6735e0ff14 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1698,6 +1698,7 @@ config RTC_DRV_SNVS

config RTC_DRV_IMX_SC
depends on IMX_SCU
+ depends on HAVE_ARM_SMCCC
tristate "NXP i.MX System Controller RTC support"
help
If you say yes here you get support for the NXP i.MX System
--
2.20.1



2019-02-08 11:00:54

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH] rtc: imx-sc: depend on HAVE_ARM_SMCCC



Best Regards!
Anson Huang

> -----Original Message-----
> From: Alexandre Belloni [mailto:[email protected]]
> Sent: 2019??2??8?? 18:06
> To: [email protected]
> Cc: Anson Huang <[email protected]>; [email protected];
> Alexandre Belloni <[email protected]>
> Subject: [PATCH] rtc: imx-sc: depend on HAVE_ARM_SMCCC
>
> Fix the following build issue:
>
> drivers/rtc/rtc-imx-sc.o: In function `imx_sc_rtc_set_time':
> >> rtc-imx-sc.c:(.text+0x212): undefined reference to `__arm_smccc_smc'
>
> Fixes: 13a929f38ad7 ("rtc: imx-sc: add rtc set time support")
> Signed-off-by: Alexandre Belloni <[email protected]>
> ---
> drivers/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index
> faa9ae1a3062..8f6735e0ff14 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1698,6 +1698,7 @@ config RTC_DRV_SNVS
>
> config RTC_DRV_IMX_SC
> depends on IMX_SCU
> + depends on HAVE_ARM_SMCCC
> tristate "NXP i.MX System Controller RTC support"
> help
> If you say yes here you get support for the NXP i.MX System
> --
> 2.20.1

Sorry for the mistake.

Reviewed-by: Anson Huang <[email protected]>