2018-08-23 06:37:43

by Anson Huang

[permalink] [raw]
Subject: [PATCH] ARM: dts: imx6ull: correct machine model name

i.MX6ULL is a lite version of i.MX6UL, its full name
is i.MX6 UltraLiteLite, NOT UlltraLite.

Signed-off-by: Anson Huang <[email protected]>
---
arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6ull-14x14-evk.dts b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
index 30ef603..0ba6454 100644
--- a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
+++ b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
@@ -45,7 +45,7 @@
#include "imx6ul-14x14-evk.dtsi"

/ {
- model = "Freescale i.MX6 UlltraLite 14x14 EVK Board";
+ model = "Freescale i.MX6 UltraLiteLite 14x14 EVK Board";
compatible = "fsl,imx6ull-14x14-evk", "fsl,imx6ull";
};

--
2.7.4



2018-08-23 06:55:47

by Stefan Wahren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6ull: correct machine model name

Hi Anson,


Am 23.08.2018 um 08:30 schrieb Anson Huang:
> i.MX6ULL is a lite version of i.MX6UL, its full name
> is i.MX6 UltraLiteLite, NOT UlltraLite.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ull-14x14-evk.dts b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> index 30ef603..0ba6454 100644
> --- a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> +++ b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> @@ -45,7 +45,7 @@
> #include "imx6ul-14x14-evk.dtsi"
>
> / {
> - model = "Freescale i.MX6 UlltraLite 14x14 EVK Board";
> + model = "Freescale i.MX6 UltraLiteLite 14x14 EVK Board";
> compatible = "fsl,imx6ull-14x14-evk", "fsl,imx6ull";
> };
>

looks good, but this compatible should be documented in
Documentation/devicetree/bindings/arm/fsl.txt (should be a separate patch).

Regards
Stefan


2018-08-23 06:57:19

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH] ARM: dts: imx6ull: correct machine model name

Hi, Stefan

Anson Huang
Best Regards!


> -----Original Message-----
> From: Stefan Wahren <[email protected]>
> Sent: Thursday, August 23, 2018 2:53 PM
> To: Anson Huang <[email protected]>; [email protected];
> [email protected]; [email protected]; Fabio Estevam
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: Re: [PATCH] ARM: dts: imx6ull: correct machine model name
>
> Hi Anson,
>
>
> Am 23.08.2018 um 08:30 schrieb Anson Huang:
> > i.MX6ULL is a lite version of i.MX6UL, its full name is i.MX6
> > UltraLiteLite, NOT UlltraLite.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > index 30ef603..0ba6454 100644
> > --- a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > +++ b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > @@ -45,7 +45,7 @@
> > #include "imx6ul-14x14-evk.dtsi"
> >
> > / {
> > - model = "Freescale i.MX6 UlltraLite 14x14 EVK Board";
> > + model = "Freescale i.MX6 UltraLiteLite 14x14 EVK Board";
> > compatible = "fsl,imx6ull-14x14-evk", "fsl,imx6ull"; };
> >
>
> looks good, but this compatible should be documented in
> Documentation/devicetree/bindings/arm/fsl.txt (should be a separate patch).

Thanks for reminder, I will update the documentation as well in V2 patch. And looks
like we missed many i.MX6 platforms there, I will update them in separate patch as well.

Anson.

>
> Regards
> Stefan

2018-08-23 07:01:01

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH] ARM: dts: imx6ull: correct machine model name

Hi, Sacha

Anson Huang
Best Regards!


> -----Original Message-----
> From: Sascha Hauer <[email protected]>
> Sent: Thursday, August 23, 2018 2:57 PM
> To: Anson Huang <[email protected]>
> Cc: [email protected]; [email protected]; Fabio Estevam
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; dl-linux-imx <[email protected]>
> Subject: Re: [PATCH] ARM: dts: imx6ull: correct machine model name
>
> Hi Anson,
>
> The board name should be in the subject to let the reader know this is no
> generic i.MX6ull change.

Thanks for comment, will fix it in V2 patch.

Anson.

>
> Sascha
>
> On Thu, Aug 23, 2018 at 02:30:49PM +0800, Anson Huang wrote:
> > i.MX6ULL is a lite version of i.MX6UL, its full name is i.MX6
> > UltraLiteLite, NOT UlltraLite.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > index 30ef603..0ba6454 100644
> > --- a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > +++ b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> > @@ -45,7 +45,7 @@
> > #include "imx6ul-14x14-evk.dtsi"
> >
> > / {
> > - model = "Freescale i.MX6 UlltraLite 14x14 EVK Board";
> > + model = "Freescale i.MX6 UltraLiteLite 14x14 EVK Board";
> > compatible = "fsl,imx6ull-14x14-evk", "fsl,imx6ull"; };
> >
> > --
> > 2.7.4
> >
> >
>
> --
> Pengutronix e.K. |
> |
> Industrial Linux Solutions |
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7C59
> 4938583dae4ac0ab1208d608c5af45%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636706042476455956&amp;sdata=bMBKPPTa17ALKbCF8jvTtIj
> dviMwKxXMW%2F%2F02xkzWO8%3D&amp;reserved=0 |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |

2018-08-23 07:17:56

by Sascha Hauer

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6ull: correct machine model name

Hi Anson,

The board name should be in the subject to let the reader know this is
no generic i.MX6ull change.

Sascha

On Thu, Aug 23, 2018 at 02:30:49PM +0800, Anson Huang wrote:
> i.MX6ULL is a lite version of i.MX6UL, its full name
> is i.MX6 UltraLiteLite, NOT UlltraLite.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ull-14x14-evk.dts b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> index 30ef603..0ba6454 100644
> --- a/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> +++ b/arch/arm/boot/dts/imx6ull-14x14-evk.dts
> @@ -45,7 +45,7 @@
> #include "imx6ul-14x14-evk.dtsi"
>
> / {
> - model = "Freescale i.MX6 UlltraLite 14x14 EVK Board";
> + model = "Freescale i.MX6 UltraLiteLite 14x14 EVK Board";
> compatible = "fsl,imx6ull-14x14-evk", "fsl,imx6ull";
> };
>
> --
> 2.7.4
>
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |