2015-11-02 11:07:17

by Vineet Gupta

[permalink] [raw]
Subject: Re: [PATCH v1 20/20] ARC: Add eznps platform to Kconfig and Makefile

On Saturday 31 October 2015 06:45 PM, Noam Camus wrote:
> From: Noam Camus <[email protected]>
>
> This commit should be left last since only now eznps platform
> is in state which one can actually use.
> Signed-off-by: Noam Camus <[email protected]>
> ---
> arch/arc/Kconfig | 1 +
> arch/arc/Makefile | 9 +++++++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index 689ccb3..8153b79 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -91,6 +91,7 @@ source "arch/arc/plat-sim/Kconfig"
> source "arch/arc/plat-tb10x/Kconfig"
> source "arch/arc/plat-axs10x/Kconfig"
> #New platform adds here
> +source "arch/arc/plat-eznps/Kconfig"
>
> endmenu
>
> diff --git a/arch/arc/Makefile b/arch/arc/Makefile
> index 8a27a48..9e5928f 100644
> --- a/arch/arc/Makefile
> +++ b/arch/arc/Makefile
> @@ -99,6 +99,15 @@ core-y += arch/arc/boot/dts/
> core-$(CONFIG_ARC_PLAT_SIM) += arch/arc/plat-sim/
> core-$(CONFIG_ARC_PLAT_TB10X) += arch/arc/plat-tb10x/
> core-$(CONFIG_ARC_PLAT_AXS10X) += arch/arc/plat-axs10x/
> +core-$(CONFIG_ARC_PLAT_EZNPS) += arch/arc/plat-eznps/
> +
> +ifdef CONFIG_ARC_PLAT_EZNPS
> +ifeq ($(KBUILD_SRC),)
> +KBUILD_CPPFLAGS += -Iarch/arc/plat-eznps/include
> +else
> +KBUILD_CPPFLAGS += -I$(srctree)/arch/arc/plat-eznps/include
> +endif
> +endif

Are you sure you need special handling for out-of-tree build. The $srctree)
version shd work just fine for both !

>
> drivers-$(CONFIG_OPROFILE) += arch/arc/oprofile/
>
>


2015-11-03 15:32:15

by Noam Camus

[permalink] [raw]
Subject: RE: [PATCH v1 20/20] ARC: Add eznps platform to Kconfig and Makefile

>From: Vineet Gupta [mailto:[email protected]]
>Sent: Monday, November 02, 2015 1:07 PM

>> +ifdef CONFIG_ARC_PLAT_EZNPS
>> +ifeq ($(KBUILD_SRC),)
>> +KBUILD_CPPFLAGS += -Iarch/arc/plat-eznps/include else KBUILD_CPPFLAGS
>> ++= -I$(srctree)/arch/arc/plat-eznps/include
>> +endif
>> +endif

>Are you sure you need special handling for out-of-tree build. The $srctree) version shd work just fine for both !
Thanks, I will use $(srctree) for both

- Noam