2017-06-29 16:25:57

by Ioana Ciocoi Radulescu

Subject: [PATCH] staging: fsl-dpaa2/eth: Remove dead code

All possible values of the switch statement are explicitly
handled, so there's no need to have a default branch.

Signed-off-by: Ioana Radulescu <[email protected]>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
index 5312edc26f01..031179ab3a22 100644
--- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
+++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
@@ -217,8 +217,6 @@ static void dpaa2_eth_get_ethtool_stats(struct net_device *net_dev,
case 2:
num_cnt = sizeof(dpni_stats.page_2) / sizeof(u64);
break;
- default:
- break;
}
for (k = 0; k < num_cnt; k++)
*(data + i++) = dpni_stats.raw.counter[k];
--
2.11.0

2017-06-30 07:19:31

by Bogdan Purcareata

Subject: RE: [PATCH] staging: fsl-dpaa2/eth: Remove dead code

> -----Original Message-----
> From: Ioana Radulescu [mailto:[email protected]]
> Sent: Thursday, June 29, 2017 7:26 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Bogdan
> Purcareata <[email protected]>; [email protected]; Laurentiu Tudor
> <[email protected]>
> Subject: [PATCH] staging: fsl-dpaa2/eth: Remove dead code
>
> All possible values of the switch statement are explicitly
> handled, so there's no need to have a default branch.
>
> Signed-off-by: Ioana Radulescu <[email protected]>

Acked-by: Bogdan Purcareata <[email protected]>

> ---
> drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> index 5312edc26f01..031179ab3a22 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> @@ -217,8 +217,6 @@ static void dpaa2_eth_get_ethtool_stats(struct
> net_device *net_dev,
> case 2:
> num_cnt = sizeof(dpni_stats.page_2) / sizeof(u64);
> break;
> - default:
> - break;
> }
> for (k = 0; k < num_cnt; k++)
> *(data + i++) = dpni_stats.raw.counter[k];
> --
> 2.11.0