2015-06-16 07:10:37

by Abdul, Hussain (H.)

Subject: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

From: Abdul Hussain <[email protected]>

This patch removes casting the values returned by memory allocation functions.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/wilc1000/linux_wlan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 5f87148..c1e9272 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -580,7 +580,7 @@ static void linux_wlan_dbg(uint8_t *buff)
static void *linux_wlan_malloc_atomic(uint32_t sz)
{
char *pntr = NULL;
- pntr = (char *)kmalloc(sz, GFP_ATOMIC);
+ pntr = kmalloc(sz, GFP_ATOMIC);
PRINT_D(MEM_DBG, "Allocating %d bytes at address %p\n", sz, pntr);
return (void *)pntr;

@@ -588,7 +588,7 @@ static void *linux_wlan_malloc_atomic(uint32_t sz)
static void *linux_wlan_malloc(uint32_t sz)
{
char *pntr = NULL;
- pntr = (char *)kmalloc(sz, GFP_KERNEL);
+ pntr = kmalloc(sz, GFP_KERNEL);
PRINT_D(MEM_DBG, "Allocating %d bytes at address %p\n", sz, pntr);
return (void *)pntr;
}
@@ -605,7 +605,7 @@ void linux_wlan_free(void *vp)
static void *internal_alloc(uint32_t size, uint32_t flag)
{
char *pntr = NULL;
- pntr = (char *)kmalloc(size, flag);
+ pntr = kmalloc(size, flag);
PRINT_D(MEM_DBG, "Allocating %d bytes at address %p\n", size, pntr);
return (void *)pntr;
}
--
1.9.1

2015-06-17 02:19:01

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

On Tue, Jun 16, 2015 at 07:10:28AM +0000, Abdul, Hussain (H.) wrote:
> From: Abdul Hussain <[email protected]>
>
> This patch removes casting the values returned by memory allocation functions.
>
> Signed-off-by: Abdul Hussain <[email protected]>
> ---
> drivers/staging/wilc1000/linux_wlan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Does not apply :(

2015-06-17 04:43:03

by Abdul, Hussain (H.)

Subject: Re: [PATCH] Staging: wilc1000: Remove casting the values returned by kmalloc()

On Wednesday 17 June 2015 07:48 AM, [email protected] wrote:
> On Tue, Jun 16, 2015 at 07:09:56AM +0000, Abdul, Hussain (H.) wrote:
>> From: Abdul Hussain <[email protected]>
>>
>> This patch removes casting the values returned by memory allocation functions.
>>
>> Signed-off-by: Abdul Hussain <[email protected]>
>> ---
>> drivers/staging/wilc1000/linux_mon.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> Does not apply :(
>
Greg,

I will verify and resend the patch.

Thanks,
Abdul