2023-09-03 13:43:54

by David Binderman

Subject: Possible cut'n'paste error in linux-6.5/drivers/thunderbolt/tmu.c

Hello there,

I just tried out static analyser cppcheck on linux-6.5. It said:

linux-6.5/drivers/thunderbolt/tmu.c:385:50: style: Expression is always false because 'else if' condition matches previous condition at line 383. [multiCondition]

Source code is

if (tmu_rates[TB_SWITCH_TMU_MODE_LOWRES] == rate)
sw->tmu.mode = TB_SWITCH_TMU_MODE_LOWRES;
else if (tmu_rates[TB_SWITCH_TMU_MODE_LOWRES] == rate)
sw->tmu.mode = TB_SWITCH_TMU_MODE_HIFI_UNI;

Regards

David Binderman