2020-09-15 07:44:09

by Biwen Li (OSS)

Subject: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

From: Biwen Li <[email protected]>

Remove useless property interrupts of rtc

Signed-off-by: Biwen Li <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index dce79018d397..e9e982176e07 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
@@ -171,8 +171,6 @@
rtc@51 {
compatible = "nxp,pcf2129";
reg = <0x51>;
- // IRQ10_B
- interrupts = <0 150 0x4>;
};
};

--
2.17.1

2020-09-22 04:38:35

by Shawn Guo

Subject: Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> From: Biwen Li <[email protected]>
>
> Remove useless property interrupts of rtc
>
> Signed-off-by: Biwen Li <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index dce79018d397..e9e982176e07 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -171,8 +171,6 @@
> rtc@51 {
> compatible = "nxp,pcf2129";
> reg = <0x51>;
> - // IRQ10_B
> - interrupts = <0 150 0x4>;

If it's a correct description of hardware, I do not see why we would
need to remove it.

Shawn

> };
> };
>
> --
> 2.17.1
>

2020-09-22 04:48:19

by Biwen Li

Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

>
> Caution: EXT Email
>
> On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > From: Biwen Li <[email protected]>
> >
> > Remove useless property interrupts of rtc
> >
> > Signed-off-by: Biwen Li <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > index dce79018d397..e9e982176e07 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > @@ -171,8 +171,6 @@
> > rtc@51 {
> > compatible = "nxp,pcf2129";
> > reg = <0x51>;
> > - // IRQ10_B
> > - interrupts = <0 150 0x4>;
>
> If it's a correct description of hardware, I do not see why we would need to
> remove it.
Hi Shawn,

Don't need use the interrupt, only read time from rtc.

Best Regards,
Biwen Li
>
> Shawn
>
> > };
> > };
> >
> > --
> > 2.17.1
> >

2020-09-22 05:15:07

by Leo Li

Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

> -----Original Message-----
> From: Biwen Li <[email protected]>
> Sent: Monday, September 21, 2020 10:13 PM
> To: Shawn Guo <[email protected]>; Biwen Li (OSS)
> <[email protected]>
> Cc: [email protected]; Leo Li <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; Jiafei Pan <[email protected]>; linux-
> [email protected]
> Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless
> property of rtc
>
> >
> > Caution: EXT Email
> >
> > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > From: Biwen Li <[email protected]>
> > >
> > > Remove useless property interrupts of rtc
> > >
> > > Signed-off-by: Biwen Li <[email protected]>
> > > ---
> > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > index dce79018d397..e9e982176e07 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > @@ -171,8 +171,6 @@
> > > rtc@51 {
> > > compatible = "nxp,pcf2129";
> > > reg = <0x51>;
> > > - // IRQ10_B
> > > - interrupts = <0 150 0x4>;
> >
> > If it's a correct description of hardware, I do not see why we would
> > need to remove it.
> Hi Shawn,
>
> Don't need use the interrupt, only read time from rtc.

User probably will choose to use the alarm feature of the RTC and need the interrupt property. Is there any issue when the interrupt property is present?

>
> Best Regards,
> Biwen Li
> >
> > Shawn
> >
> > > };
> > > };
> > >
> > > --
> > > 2.17.1
> > >