From: Peng Fan <[email protected]>
Add mu node to let A53 could communicate with M Core.
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 73535601261e..0b127a25657a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -621,6 +621,15 @@
status = "disabled";
};
+ mu: mailbox@30aa0000 {
+ compatible = "fsl,imx6sx-mu";
+ reg = <0x30aa0000 0x10000>;
+ interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MP_CLK_MU_ROOT>;
+ clock-names = "mu";
+ #mbox-cells = <2>;
+ };
+
i2c5: i2c@30ad0000 {
compatible = "fsl,imx8mp-i2c", "fsl,imx21-i2c";
#address-cells = <1>;
--
2.16.4
Hi Peng,
On Tue, May 19, 2020 at 11:15 PM <[email protected]> wrote:
> + mu: mailbox@30aa0000 {
> + compatible = "fsl,imx6sx-mu";
This should be better described as:
compatible = "fsl,imx8mp-mu", "fsl,imx6sx-mu";
From Documentation/devicetree/bindings/mailbox/fsl,mu.txt:
"The "fsl,imx6sx-mu" compatible is seen as generic and should
be included together with SoC specific compatible."
> Subject: Re: [PATCH 3/3] arm64: dts: imx8mp: add mu node
>
> Hi Peng,
>
> On Tue, May 19, 2020 at 11:15 PM <[email protected]> wrote:
>
> > + mu: mailbox@30aa0000 {
> > + compatible = "fsl,imx6sx-mu";
>
> This should be better described as:
>
> compatible = "fsl,imx8mp-mu", "fsl,imx6sx-mu";
>
> From Documentation/devicetree/bindings/mailbox/fsl,mu.txt:
>
> "The "fsl,imx6sx-mu" compatible is seen as generic and should be included
> together with SoC specific compatible."
Nothing specific in i.MX8MP for the mu part, so do we really need
add "fsl,imx8mp-mu"?
Thanks,
Peng.
Hi Peng,
On Wed, May 20, 2020 at 12:01 AM Peng Fan <[email protected]> wrote:
> Nothing specific in i.MX8MP for the mu part, so do we really need
> add "fsl,imx8mp-mu"?
It is good practice to add a more specific option.
Let's say in future a bug is found that affects imx8mp MU, then you
could fix the MU driver and keep the dtb compatibility.
> Subject: Re: [PATCH 3/3] arm64: dts: imx8mp: add mu node
>
> Hi Peng,
>
> On Wed, May 20, 2020 at 12:01 AM Peng Fan <[email protected]> wrote:
>
> > Nothing specific in i.MX8MP for the mu part, so do we really need add
> > "fsl,imx8mp-mu"?
>
> It is good practice to add a more specific option.
>
> Let's say in future a bug is found that affects imx8mp MU, then you could fix
> the MU driver and keep the dtb compatibility.
Got it. Thanks for the tips.
Thanks,
Peng.
> From: Fabio Estevam <[email protected]>
> Sent: Wednesday, May 20, 2020 11:07 AM
>
> Hi Peng,
>
> On Wed, May 20, 2020 at 12:01 AM Peng Fan <[email protected]> wrote:
>
> > Nothing specific in i.MX8MP for the mu part, so do we really need add
> > "fsl,imx8mp-mu"?
>
> It is good practice to add a more specific option.
>
> Let's say in future a bug is found that affects imx8mp MU, then you could fix the
> MU driver and keep the dtb compatibility.
+1