2020-04-29 09:51:18

by Peng Fan

[permalink] [raw]
Subject: [PATCH] soc: imx: select ARM_GIC_V3 for i.MX8M

From: Peng Fan <[email protected]>

Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32
mode linux on aarch64 hardware. For aarch64 mode, it not hurts
to select ARM_GIC_V3.

Acked-by: Arnd Bergmann <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
drivers/soc/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 67aa94b2481b..f4006b784312 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -20,7 +20,8 @@ config IMX_SCU_SOC
config SOC_IMX8M
bool "i.MX8M SoC family support"
depends on ARCH_MXC || COMPILE_TEST
- default ARCH_MXC && ARM64
+ default ARCH_MXC
+ select ARM_GIC_V3
help
If you say yes here you get support for the NXP i.MX8M family
support, it will provide the SoC info like SoC family,
--
2.16.4


2020-04-29 09:53:38

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH] soc: imx: select ARM_GIC_V3 for i.MX8M

Hi Shawn,

> Subject: [PATCH] soc: imx: select ARM_GIC_V3 for i.MX8M

Forget to use v2 and mention that this is resend
https://patchwork.kernel.org/patch/11435941/

If you need v2, I could resend with v2.

Thanks,
Peng.

>
> From: Peng Fan <[email protected]>
>
> Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32 mode linux
> on aarch64 hardware. For aarch64 mode, it not hurts to select ARM_GIC_V3.
>
> Acked-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> drivers/soc/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> 67aa94b2481b..f4006b784312 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -20,7 +20,8 @@ config IMX_SCU_SOC
> config SOC_IMX8M
> bool "i.MX8M SoC family support"
> depends on ARCH_MXC || COMPILE_TEST
> - default ARCH_MXC && ARM64
> + default ARCH_MXC
> + select ARM_GIC_V3
> help
> If you say yes here you get support for the NXP i.MX8M family
> support, it will provide the SoC info like SoC family,
> --
> 2.16.4

2020-04-30 10:42:32

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH] soc: imx: select ARM_GIC_V3 for i.MX8M

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shawnguo/for-next]
[cannot apply to v5.7-rc3 next-20200429]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/peng-fan-nxp-com/soc-imx-select-ARM_GIC_V3-for-i-MX8M/20200429-195805
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=mips

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <[email protected]>

All errors (new ones prefixed by >>):

In file included from drivers/irqchip/irq-gic-v3.c:24:
>> include/linux/irqchip/arm-gic-v3.h:661:10: fatal error: asm/arch_gicv3.h: No such file or directory
661 | #include <asm/arch_gicv3.h>
| ^~~~~~~~~~~~~~~~~~
compilation terminated.

vim +661 include/linux/irqchip/arm-gic-v3.h

7e5802781c3e10 Andre Przywara 2014-11-12 660
7936e914f7b082 Jean-Philippe Brucker 2015-10-01 @661 #include <asm/arch_gicv3.h>
021f653791ad17 Marc Zyngier 2014-06-30 662

:::::: The code at line 661 was first introduced by commit
:::::: 7936e914f7b0827c2dcfe63fbefdc21de2d61dcb irqchip/gic-v3: Refactor the arm64 specific parts

:::::: TO: Jean-Philippe Brucker <[email protected]>
:::::: CC: Marc Zyngier <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (2.00 kB)
.config.gz (64.01 kB)
Download all attachments