Hi Michael and Stephen,
This patch set was acked by Rob Herring. Do you have any comments on them?
BTW: Scott should stay in author, do I need to resend them with author changed or you can change it when applying?
Regards,
Yuantian
> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: Tuesday, February 28, 2017 1:19 AM
> To: Y.T. Tang
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; Scott Wood
> Subject: Re: [PATCH 1/2] dt-bindings: qoriq-clock: Add coreclk
>
> On Wed, Feb 15, 2017 at 01:47:35PM +0800, [email protected] wrote:
> > From: Tang Yuantian <[email protected]>
> >
> > ls1012a has separate input root clocks for core PLLs versus the
> > platform PLL, with the latter described as sysclk in the hw docs.
> > Update the qoriq-clock binding to allow a second input clock, named
> > "coreclk". If present, this clock will be used for the core PLLs.
> >
> > Signed-off-by: Scott Wood <[email protected]>
> > Signed-off-by: Tang Yuantian <[email protected]>
> > ---
> > Documentation/devicetree/bindings/clock/qoriq-clock.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> The change looks fine, but sounds like Scott should remain the author (or
> agree he shouldn't be).
>
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > index df9cb5a..97a9666 100644
> > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > @@ -55,6 +55,11 @@ Optional properties:
> > - clocks: If clock-frequency is not specified, sysclk may be provided
> > as an input clock. Either clock-frequency or clocks must be
> > provided.
> > + A second input clock, called "coreclk", may be provided if
> > + core PLLs are based on a different input clock from the
> > + platform PLL.
> > +- clock-names: Required if a coreclk is present. Valid names are
> > + "sysclk" and "coreclk".
> >
> > 2. Clock Provider
> >
> > @@ -71,6 +76,7 @@ second cell is the clock index for the specified type.
> > 2 hwaccel index (n in CLKCGnHWACSR)
> > 3 fman 0 for fm1, 1 for fm2
> > 4 platform pll 0=pll, 1=pll/2, 2=pll/3, 3=pll/4
> > + 5 coreclk must be 0
> >
> > 3. Example
> >
> > --
> > 2.1.0.27.g96db324
> >
On 03/09, Y.T. Tang wrote:
> Hi Michael and Stephen,
>
> This patch set was acked by Rob Herring. Do you have any comments on them?
>
> BTW: Scott should stay in author, do I need to resend them with author changed or you can change it when applying?
>
Please resend these two patches.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Hi,
> -----Original Message-----
> From: [email protected] [mailto:[email protected]]
> Sent: Saturday, July 22, 2017 6:03 AM
> To: Andy Tang <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Scott Wood
> <[email protected]>; Rob Herring <[email protected]>
> Subject: Re: [PATCH 1/2] dt-bindings: qoriq-clock: Add coreclk
>
> On 03/09, Y.T. Tang wrote:
> > Hi Michael and Stephen,
> >
> > This patch set was acked by Rob Herring. Do you have any comments on
> them?
> >
> > BTW: Scott should stay in author, do I need to resend them with author
> changed or you can change it when applying?
> >
>
> Please resend these two patches.
Those two patches have been merged several months ago. No need to resend.
Thanks.
Regards,
Andy
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
> Linux Foundation Collaborative Project