2022-12-07 07:57:03

by ye.xingchen

Subject: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/iio/adc/vf610_adc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index ae31aafd2653..dbf80f5f674b 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -606,8 +606,7 @@ static ssize_t vf610_show_samp_freq_avail(struct device *dev,
int i;

for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
- len += scnprintf(buf + len, PAGE_SIZE - len,
- "%u ", info->sample_freq_avail[i]);
+ len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);

/* replace trailing space by newline */
buf[len - 1] = '\n';
--
2.25.1

2022-12-09 08:40:57

by Bough Chen

Subject: RE: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: 2022年12月7日 15:35
> To: [email protected]
> Cc: Bough Chen <[email protected]>; [email protected];
> [email protected]; [email protected]; dl-linux-imx <[email protected]>;
> [email protected]
> Subject: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API
>
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should
> only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
> returned to user space.
>
> Signed-off-by: ye xingchen <[email protected]>

Acked-by: Haibo Chen <[email protected]>

Best Regards
Haibo Chen
> ---
> drivers/iio/adc/vf610_adc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
> ae31aafd2653..dbf80f5f674b 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -606,8 +606,7 @@ static ssize_t vf610_show_samp_freq_avail(struct
> device *dev,
> int i;
>
> for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
> - len += scnprintf(buf + len, PAGE_SIZE - len,
> - "%u ", info->sample_freq_avail[i]);
> + len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);
>
> /* replace trailing space by newline */
> buf[len - 1] = '\n';
> --
> 2.25.1