2023-07-06 03:54:29

by 李扬韬

Subject: [PATCH 4/7] spi: spi-nxp-fspi: Convert to devm_platform_ioremap_resource() and devm_platform_ioremap_resource_byname()

Use devm_platform_ioremap_resource() and
devm_platform_ioremap_resource_byname() to simplify code.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/spi/spi-nxp-fspi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index 544017655787..4cf9b3bf7b57 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1157,12 +1157,10 @@ static int nxp_fspi_probe(struct platform_device *pdev)

/* find the resources - configuration register address space */
if (is_acpi_node(dev_fwnode(f->dev)))
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ f->iobase = devm_platform_ioremap_resource(pdev, 0);
else
- res = platform_get_resource_byname(pdev,
- IORESOURCE_MEM, "fspi_base");
+ f->iobase = devm_platform_ioremap_resource_byname(pdev, "fspi_base");

- f->iobase = devm_ioremap_resource(dev, res);
if (IS_ERR(f->iobase)) {
ret = PTR_ERR(f->iobase);
goto err_put_ctrl;
--
2.39.0

2023-07-06 06:15:45

by Bough Chen

Subject: RE: [PATCH 4/7] spi: spi-nxp-fspi: Convert to devm_platform_ioremap_resource() and devm_platform_ioremap_resource_byname()

> -----Original Message-----
> From: Yangtao Li <[email protected]>
> Sent: 2023??7??6?? 11:27
> To: Han Xu <[email protected]>; Bough Chen <[email protected]>; Yogesh
> Gaur <[email protected]>; Mark Brown <[email protected]>
> Cc: Yangtao Li <[email protected]>; [email protected];
> [email protected]
> Subject: [PATCH 4/7] spi: spi-nxp-fspi: Convert to
> devm_platform_ioremap_resource() and
> devm_platform_ioremap_resource_byname()
>
> Use devm_platform_ioremap_resource() and
> devm_platform_ioremap_resource_byname() to simplify code.

Thanks!

Reviewed-by: Haibo Chen <[email protected]>

Best Regards
Haibo Chen

>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/spi/spi-nxp-fspi.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index
> 544017655787..4cf9b3bf7b57 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -1157,12 +1157,10 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>
> /* find the resources - configuration register address space */
> if (is_acpi_node(dev_fwnode(f->dev)))
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + f->iobase = devm_platform_ioremap_resource(pdev, 0);
> else
> - res = platform_get_resource_byname(pdev,
> - IORESOURCE_MEM, "fspi_base");
> + f->iobase = devm_platform_ioremap_resource_byname(pdev,
> "fspi_base");
>
> - f->iobase = devm_ioremap_resource(dev, res);
> if (IS_ERR(f->iobase)) {
> ret = PTR_ERR(f->iobase);
> goto err_put_ctrl;
> --
> 2.39.0