2020-08-15 21:59:44

by Oded Gabbay

Subject: [PATCH 2/9] habanalabs: cast int to u32 before printing it with %u

%u is used for unsigned so we need to cast the int variable to u32 to avoid
compiler warning.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Oded Gabbay <[email protected]>
---
drivers/misc/habanalabs/common/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c
index 35214a186913..38895493a0ed 100644
--- a/drivers/misc/habanalabs/common/device.c
+++ b/drivers/misc/habanalabs/common/device.c
@@ -286,7 +286,7 @@ static int device_early_init(struct hl_device *hdev)
}

for (i = 0 ; i < hdev->asic_prop.completion_queues_count ; i++) {
- snprintf(workq_name, 32, "hl-free-jobs-%u", i);
+ snprintf(workq_name, 32, "hl-free-jobs-%u", (u32) i);
hdev->cq_wq[i] = create_singlethread_workqueue(workq_name);
if (hdev->cq_wq[i] == NULL) {
dev_err(hdev->dev, "Failed to allocate CQ workqueue\n");
--
2.17.1

2020-08-16 15:25:51

by Tomer Tayar

Subject: RE: [PATCH 2/9] habanalabs: cast int to u32 before printing it with %u

On Sat, Aug 15, 2020 at 21:00 Oded Gabbay <[email protected]> wrote:
> %u is used for unsigned so we need to cast the int variable to u32 to avoid
> compiler warning.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Oded Gabbay <[email protected]>

Reviewed-by: Tomer Tayar <[email protected]>