2023-07-18 02:33:13

by Ming Qian

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH] media: amphion: fix some issues reported by coverity

>From: Markus Elfring <[email protected]>
>Sent: 2023??7??18?? 1:26
>To: Ming Qian <[email protected]>; [email protected]; kernel-
>[email protected]; [email protected]; dl-linux-imx
><[email protected]>; [email protected]; Fabio Estevam
><[email protected]>; Hans Verkuil <[email protected]>; Mauro
>Carvalho Chehab <[email protected]>; Nicolas Dufresne
><[email protected]>; Rob Herring <[email protected]>; Sascha Hauer
><[email protected]>; Shawn Guo <[email protected]>; Tao Jiang
><[email protected]>; X.H. Bao <[email protected]>; Eagle Zhou
><[email protected]>
>Cc: LKML <[email protected]>
>Subject: [EXT] Re: [PATCH] media: amphion: fix some issues reported by
>coverity
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>> CHECKED_RETURN: 4 case
>> REVERSE_INULL: 2 case
>> UNINIT: 6 case
>> UNUSED_VALUE: 1 case
>
>How does such a change combination fit to the development requirement
>??Solve only one problem per patch.???
>
>See also:
>https://git.ker/
>nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Ft
>ree%2FDocumentation%2Fprocess%2Fsubmitting-patches.rst%3Fh%3Dv6.5-
>rc2%23n81&data=05%7C01%7Cming.qian%40nxp.com%7C94575f499df74c702
>d8308db86ead678%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
>8252115406304424%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
>LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd
>ata=nr7bqZMPNvrECSOMJsCzn3aU8UWdinBG4sHRRGRJJ1E%3D&reserved=0
>
>
>Will further imperative change descriptions become more helpful?
>
>Regards,
>Markus

Hi Markus,
Thanks for your comments, I'll split this patch into 4 patches, one topic one patch.

Ming