2021-06-17 02:27:25

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tags need some work in the net tree

Hi all,

In commit

cb3cefe3f3f8 ("net: fec_ptp: add clock rate zero check")

Fixes tag

Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")

has these problem(s):

- leading word 'commit' unexpected

In commit

8f269102baf7 ("net: stmmac: disable clocks in stmmac_remove_config_dt()")

Fixes tag

Fixes: commit d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks")

has these problem(s):

- leading word 'commit' unexpected

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-06-17 02:49:07

by Joakim Zhang

[permalink] [raw]
Subject: RE: linux-next: Fixes tags need some work in the net tree


Hi Stephen,

Thanks for reporting this, it's a mistake when adding Fixes tag. And ./scripts/checkpatch.pl script seems can't
report this issue(even with --strict parameter).

Could you tell me how can you get these errors before sending out the patches for reviewing?

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Stephen Rothwell <[email protected]>
> Sent: 2021??6??17?? 6:03
> To: David Miller <[email protected]>; Networking
> <[email protected]>
> Cc: Fugang Duan <[email protected]>; Joakim Zhang
> <[email protected]>; Linux Kernel Mailing List
> <[email protected]>; Linux Next Mailing List
> <[email protected]>
> Subject: linux-next: Fixes tags need some work in the net tree
>
> Hi all,
>
> In commit
>
> cb3cefe3f3f8 ("net: fec_ptp: add clock rate zero check")
>
> Fixes tag
>
> Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")
>
> has these problem(s):
>
> - leading word 'commit' unexpected
>
> In commit
>
> 8f269102baf7 ("net: stmmac: disable clocks in
> stmmac_remove_config_dt()")
>
> Fixes tag
>
> Fixes: commit d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and
> fixed-link-phydev leaks")
>
> has these problem(s):
>
> - leading word 'commit' unexpected
>
> --
> Cheers,
> Stephen Rothwell