2020-07-22 07:55:17

by Chunfeng Yun

Subject: [PATCH 3/7] usb: cdns3: convert to devm_platform_ioremap_resource_byname

Use devm_platform_ioremap_resource_byname() to simplify code

Cc: Peter Chen <[email protected]>
Signed-off-by: Chunfeng Yun <[email protected]>
---
drivers/usb/cdns3/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
index 19bbb5b..24faf60 100644
--- a/drivers/usb/cdns3/core.c
+++ b/drivers/usb/cdns3/core.c
@@ -436,8 +436,7 @@ static int cdns3_probe(struct platform_device *pdev)
if (cdns->dev_irq < 0)
dev_err(dev, "couldn't get peripheral irq\n");

- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dev");
- regs = devm_ioremap_resource(dev, res);
+ regs = devm_platform_ioremap_resource_byname(pdev, "dev");
if (IS_ERR(regs))
return PTR_ERR(regs);
cdns->dev_regs = regs;
--
1.9.1

2020-07-22 08:47:21

by Peter Chen

Subject: RE: [PATCH 3/7] usb: cdns3: convert to devm_platform_ioremap_resource_byname

> Use devm_platform_ioremap_resource_byname() to simplify code
>
> Cc: Peter Chen <[email protected]>
> Signed-off-by: Chunfeng Yun <[email protected]>
> ---
> drivers/usb/cdns3/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index
> 19bbb5b..24faf60 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -436,8 +436,7 @@ static int cdns3_probe(struct platform_device *pdev)
> if (cdns->dev_irq < 0)
> dev_err(dev, "couldn't get peripheral irq\n");
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dev");
> - regs = devm_ioremap_resource(dev, res);
> + regs = devm_platform_ioremap_resource_byname(pdev, "dev");
> if (IS_ERR(regs))
> return PTR_ERR(regs);
> cdns->dev_regs = regs;
> --

Reviewed-by: Peter Chen <[email protected]>

Peter