2021-11-29 07:29:21

by Nikita Shubin

Subject: [PATCH v3] rtc: da9063: add as wakeup source

As da9063 RTC is not a real I2C client, but relies on da9063 MFD
driver, we need to explicitly mark da9063 RTC as a wakeup source
to be able to access class/rtc/rtcN/wakealarm sysfs entry
to set alarms, so we can wakeup from SHUTDOWN/RTC/DELIVERY mode.

As da9063 driver refuses to load without irq, we simply add it
as a wakeup source before registering rtc device.

Signed-off-by: Nikita Shubin <[email protected]>
---
v2->v3:
Adam Thomson:
Commit message more verbose.
---
drivers/rtc/rtc-da9063.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index d4b72a9fa2ba..b9a73356bace 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -494,6 +494,8 @@ static int da9063_rtc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
irq_alarm, ret);

+ device_init_wakeup(&pdev->dev, true);
+
return devm_rtc_register_device(rtc->rtc_dev);
}

--
2.31.1

2021-11-29 11:06:05

by Adam Thomson

Subject: RE: [PATCH v3] rtc: da9063: add as wakeup source

On 29 November 2021 07:27, Nikita Shubin wrote:

> As da9063 RTC is not a real I2C client, but relies on da9063 MFD
> driver, we need to explicitly mark da9063 RTC as a wakeup source
> to be able to access class/rtc/rtcN/wakealarm sysfs entry
> to set alarms, so we can wakeup from SHUTDOWN/RTC/DELIVERY mode.
>
> As da9063 driver refuses to load without irq, we simply add it
> as a wakeup source before registering rtc device.
>
> Signed-off-by: Nikita Shubin <[email protected]>
> ---

Thanks for the update.

Reviewed-by: Adam Thomson <[email protected]>

2021-12-02 22:24:32

by Alexandre Belloni

Subject: Re: [PATCH v3] rtc: da9063: add as wakeup source

On Mon, 29 Nov 2021 10:26:49 +0300, Nikita Shubin wrote:
> As da9063 RTC is not a real I2C client, but relies on da9063 MFD
> driver, we need to explicitly mark da9063 RTC as a wakeup source
> to be able to access class/rtc/rtcN/wakealarm sysfs entry
> to set alarms, so we can wakeup from SHUTDOWN/RTC/DELIVERY mode.
>
> As da9063 driver refuses to load without irq, we simply add it
> as a wakeup source before registering rtc device.
>
> [...]

Applied, thanks!

[1/1] rtc: da9063: add as wakeup source
commit: 029d3a6f2f3c73ac29a7460d8007798e940488fd

Best regards,
--
Alexandre Belloni <[email protected]>