2020-12-09 01:13:29

by Randy Dunlap

Subject: [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set

Fix a build warning when USB_CDNS_HOST is not enabled:

In file included from ../drivers/usb/cdns3/core.c:23:0:
../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared inside parameter list will not be visible outside of this definition or declaration
static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
^~~~~~~

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Peter Chen <[email protected]>
Cc: Pawel Laszczak <[email protected]>
Cc: Roger Quadros <[email protected]>
Cc: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>
---
drivers/usb/cdns3/host-export.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h
+++ linux-next-20201208/drivers/usb/cdns3/host-export.h
@@ -9,10 +9,10 @@
#ifndef __LINUX_CDNS3_HOST_EXPORT
#define __LINUX_CDNS3_HOST_EXPORT

-#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
-
struct usb_hcd;

+#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
+
int cdns_host_init(struct cdns *cdns);
int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);

2020-12-09 02:45:08

by Peter Chen

Subject: RE: [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set

> In file included from ../drivers/usb/cdns3/core.c:23:0:
> ../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared
> inside parameter list will not be visible outside of this definition or declaration
> static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> ^~~~~~~
>

Applied both, thanks.

Peter

> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Peter Chen <[email protected]>
> Cc: Pawel Laszczak <[email protected]>
> Cc: Roger Quadros <[email protected]>
> Cc: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/usb/cdns3/host-export.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h
> +++ linux-next-20201208/drivers/usb/cdns3/host-export.h
> @@ -9,10 +9,10 @@
> #ifndef __LINUX_CDNS3_HOST_EXPORT
> #define __LINUX_CDNS3_HOST_EXPORT
>
> -#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> -
> struct usb_hcd;
>
> +#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> +
> int cdns_host_init(struct cdns *cdns);
> int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
>