2014-04-16 21:43:07

by Hartley Sweeten

[permalink] [raw]
Subject: RE: [PATCH 1/2] staging: comedi: addi_apci_1564: remove use of devpriv->iobase

On Monday, April 14, 2014 10:54 PM, Chase Southwood wrote:
> devpriv->iobase is currently being used to hold the iobase address used to
> read/write the board's registers. The same address is stored in the
> comedi_device dev->iobase. We use that instead. The eventual goal is to
> decrease the driver's use of the struct addi_private, so that it may
> eventually use a much slimmer specialized private struct instead, as the
> other addi_apci_* drivers do.
>
> Signed-off-by: Chase Southwood <[email protected]>
> Cc: H Hartley Sweeten <[email protected]>
> ---
> This is a (small) first patchset for my more complete cleanup of
> addi_apci_1564 driver. Hartley, I'd appreciate any review you have
> wrt these specific patches, but also whether I have chosen a good place
> to start.

As good a place as any to start...

Reviewed-by: H Hartley Sweeten <[email protected]>