2014-06-27 23:17:12

by Yue Zhang (OSTC DEV)

Subject: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon

From: Yue Zhang <[email protected]>

hv_fcopy_daemon fails to overwrite a file if the target file already
exits.

Add O_TRUNC flag on opening.

MS-TFS: 341345

Signed-off-by: Yue Zhang <[email protected]>
---
tools/hv/hv_fcopy_daemon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
index fba1c75..2a86297 100644
--- a/tools/hv/hv_fcopy_daemon.c
+++ b/tools/hv/hv_fcopy_daemon.c
@@ -88,7 +88,8 @@ static int hv_start_fcopy(struct hv_start_fcopy *smsg)
}
}

- target_fd = open(target_fname, O_RDWR | O_CREAT | O_CLOEXEC, 0744);
+ target_fd = open(target_fname,
+ O_RDWR | O_CREAT | O_TRUNC | O_CLOEXEC, 0744);
if (target_fd == -1) {
syslog(LOG_INFO, "Open Failed: %s", strerror(errno));
goto done;
--
1.9.1

2014-06-27 23:20:14

by KY Srinivasan

Subject: RE: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon

> -----Original Message-----
> From: Yue Zhang [mailto:[email protected]]
> Sent: Friday, June 27, 2014 5:17 PM
> To: KY Srinivasan; Haiyang Zhang; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: Dexuan Cui; Thomas Shao
> Subject: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon
>
> From: Yue Zhang <[email protected]>
>
> hv_fcopy_daemon fails to overwrite a file if the target file already exits.
>
> Add O_TRUNC flag on opening.
>
> MS-TFS: 341345
You need to include Greg in the "to list". Also get rid of the MS-TFS tag.

>
> Signed-off-by: Yue Zhang <[email protected]>
> ---
> tools/hv/hv_fcopy_daemon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
> index fba1c75..2a86297 100644
> --- a/tools/hv/hv_fcopy_daemon.c
> +++ b/tools/hv/hv_fcopy_daemon.c
> @@ -88,7 +88,8 @@ static int hv_start_fcopy(struct hv_start_fcopy *smsg)
> }
> }
>
> - target_fd = open(target_fname, O_RDWR | O_CREAT | O_CLOEXEC,
> 0744);
> + target_fd = open(target_fname,
> + O_RDWR | O_CREAT | O_TRUNC | O_CLOEXEC,
> 0744);
Please align properly and there is no need for three lines here.

K. Y

2014-06-27 23:41:05

by Greg KH

Subject: Re: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon

On Fri, Jun 27, 2014 at 05:16:48PM -0700, Yue Zhang wrote:
> From: Yue Zhang <[email protected]>
>
> hv_fcopy_daemon fails to overwrite a file if the target file already
> exits.
>
> Add O_TRUNC flag on opening.
>
> MS-TFS: 341345

It's as if the people on your team don't talk to each other about what
they should, or should not, include in their patch descriptions...

Please remove.

greg k-h

2014-06-27 23:50:09

by Yue Zhang (OSTC DEV)

Subject: RE: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon

> -----Original Message-----
> From: Greg KH [mailto:[email protected]]
> > From: Yue Zhang <[email protected]>
> >
> > hv_fcopy_daemon fails to overwrite a file if the target file already
> > exits.
> >
> > Add O_TRUNC flag on opening.
> >
> > MS-TFS: 341345
>
> It's as if the people on your team don't talk to each other about what they
> should, or should not, include in their patch descriptions...
>
> Please remove.

Sorry for this. It is added by mistake. I will remove it.

Yue Zhang