Il 12/12/2013 12:09, Liu, Jinsong ha scritto:
> Paolo Bonzini wrote:
>> Il 12/12/2013 06:47, Liu, Jinsong ha scritto:
>>> Paolo Bonzini wrote:
>>>> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>>>>> Paolo, comments for version 2?
>>>>
>>>> I think I commented that it's fine, I'm just waiting for a rebase
>>>> on top of the generic patches.
>>>>
>>>> Paolo
>>>>
>>>
>>> Thanks! common MPX definiation patches have been checked in tip tree
>>> (both Qiaowei and I use that definiations):
>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669
>>
>> Ok, can you rebase and resend?
>>
>> Paolo
>
> Sure, I have pulled and rebased on git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> No confliction, patches v3 will send out later.
Didn't see this... You still have a couple of days to send it out and
address the review remarks.
Paolo
Paolo Bonzini wrote:
> Il 12/12/2013 12:09, Liu, Jinsong ha scritto:
>> Paolo Bonzini wrote:
>>> Il 12/12/2013 06:47, Liu, Jinsong ha scritto:
>>>> Paolo Bonzini wrote:
>>>>> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>>>>>> Paolo, comments for version 2?
>>>>>
>>>>> I think I commented that it's fine, I'm just waiting for a rebase
>>>>> on top of the generic patches.
>>>>>
>>>>> Paolo
>>>>>
>>>>
>>>> Thanks! common MPX definiation patches have been checked in tip
>>>> tree (both Qiaowei and I use that definiations):
>>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
>>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669
>>>
>>> Ok, can you rebase and resend?
>>>
>>> Paolo
>>
>> Sure, I have pulled and rebased on
>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git No
>> confliction, patches v3 will send out later.
>
> Didn't see this... You still have a couple of days to send it out and
> address the review remarks.
>
> Paolo
Hmm? I remember I have sent out the rebased patches v3 last month ... If you didn't receive them I'm OK to rebase and resend them. BTW, what's the review remarks? I remember you commented that the patches are fine. Any misunderstanding please point out to me.
Thanks,
Jinsong-
Il 21/01/2014 16:25, Liu, Jinsong ha scritto:
> Hmm? I remember I have sent out the rebased patches v3 last month
> If you didn't receive them I'm OK to rebase and resend them. BTW, what's
> the review remarks? I remember you commented that the patches are fine.
> Any misunderstanding please point out to me.
You sent v3 of QEMU, but not of KVM. I don't see any mail from you
after December 12th on [email protected].
I can see my comment that the patches were fine (apart from needing a
rebase), but the threading was wrong and I cannot find anymore _which_
patches they were. I did find a comment that BNDCFGS must be added to
msrs_to_save, but I don't know if that was v1 or v2 because you didn't
add the version number when sending v2.
Paolo
Paolo Bonzini wrote:
> Il 21/01/2014 16:25, Liu, Jinsong ha scritto:
>> Hmm? I remember I have sent out the rebased patches v3 last month
>> If you didn't receive them I'm OK to rebase and resend them. BTW,
>> what's the review remarks? I remember you commented that the patches
>> are fine. Any misunderstanding please point out to me.
>
> You sent v3 of QEMU, but not of KVM. I don't see any mail from you
> after December 12th on [email protected].
>
> I can see my comment that the patches were fine (apart from needing a
> rebase), but the threading was wrong and I cannot find anymore _which_
> patches they were. I did find a comment that BNDCFGS must be added to
> msrs_to_save, but I don't know if that was v1 or v2 because you didn't
> add the version number when sending v2.
>
> Paolo
So I don't need resend qemu patches, just rebase and resend KVM MPX patches, is that right?
Thanks,
Jinsong-