2022-04-25 07:57:22

by Liu, Zhan

Subject: RE: [PATCH] drm/amd/display: fix if == else warning

[AMD Official Use Only - General]

> -----Original Message-----
> From: Guo Zhengkui <[email protected]>
> Sent: 2022/April/24, Sunday 5:06 AM
> To: Wentland, Harry <[email protected]>; Li, Sun peng (Leo)
> <[email protected]>; Siqueira, Rodrigo <[email protected]>;
> Deucher, Alexander <[email protected]>; Koenig, Christian
> <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie
> <[email protected]>; Daniel Vetter <[email protected]>; Liu, Charlene
> <[email protected]>; Lei, Jun <[email protected]>; Guo Zhengkui
> <[email protected]>; Liu, Zhan <[email protected]>; Jos? Exp?sito
> <[email protected]>; open list:AMD DISPLAY CORE <amd-
> [email protected]>; open list:DRM DRIVERS <dri-
> [email protected]>; open list <[email protected]>
> Cc: [email protected]
> Subject: [PATCH] drm/amd/display: fix if == else warning
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10:
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Guo Zhengkui <[email protected]>

Thanks a lot for fixing this warning.

Reviewed-by: Zhan Liu <[email protected]>

> ---
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> index fe22530242d2..05b3fba9ccce 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq,
> } else if (hwseq->fb_offset.quad_part <= addr->quad_part &&
> addr->quad_part <= hwseq->uma_top.quad_part) {
> is_in_uma = true;
> - } else if (addr->quad_part == 0) {
> - is_in_uma = false;
> } else {
> is_in_uma = false;
> }
> --
> 2.20.1

2022-04-26 03:36:35

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: fix if == else warning

Applied. Thanks!

Alex

On Sun, Apr 24, 2022 at 4:15 PM Liu, Zhan <[email protected]> wrote:
>
> [AMD Official Use Only - General]
>
> > -----Original Message-----
> > From: Guo Zhengkui <[email protected]>
> > Sent: 2022/April/24, Sunday 5:06 AM
> > To: Wentland, Harry <[email protected]>; Li, Sun peng (Leo)
> > <[email protected]>; Siqueira, Rodrigo <[email protected]>;
> > Deucher, Alexander <[email protected]>; Koenig, Christian
> > <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie
> > <[email protected]>; Daniel Vetter <[email protected]>; Liu, Charlene
> > <[email protected]>; Lei, Jun <[email protected]>; Guo Zhengkui
> > <[email protected]>; Liu, Zhan <[email protected]>; José Expósito
> > <[email protected]>; open list:AMD DISPLAY CORE <amd-
> > [email protected]>; open list:DRM DRIVERS <dri-
> > [email protected]>; open list <[email protected]>
> > Cc: [email protected]
> > Subject: [PATCH] drm/amd/display: fix if == else warning
> >
> > Fix the following coccicheck warning:
> >
> > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10:
> > WARNING: possible condition with no effect (if == else)
> >
> > Signed-off-by: Guo Zhengkui <[email protected]>
>
> Thanks a lot for fixing this warning.
>
> Reviewed-by: Zhan Liu <[email protected]>
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > index fe22530242d2..05b3fba9ccce 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> > @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq,
> > } else if (hwseq->fb_offset.quad_part <= addr->quad_part &&
> > addr->quad_part <= hwseq->uma_top.quad_part) {
> > is_in_uma = true;
> > - } else if (addr->quad_part == 0) {
> > - is_in_uma = false;
> > } else {
> > is_in_uma = false;
> > }
> > --
> > 2.20.1
>